From: David Miller <davem@davemloft.net>
To: marcel@holtmann.org
Cc: netdev@vger.kernel.org, kay.sievers@vrfy.org, greg@kroah.com,
johannes@sipsolutions.net
Subject: Re: [PATCH 5/6]: nl80211: Eliminate reference to BUS_ID_SIZE.
Date: Thu, 28 May 2009 01:08:30 -0700 (PDT) [thread overview]
Message-ID: <20090528.010830.45004716.davem@davemloft.net> (raw)
In-Reply-To: <1243495643.16631.7.camel@localhost.localdomain>
From: Marcel Holtmann <marcel@holtmann.org>
Date: Thu, 28 May 2009 09:27:23 +0200
>> @@ -57,7 +57,7 @@ static int get_drv_dev_by_info_ifindex(struct nlattr **attrs,
>> static struct nla_policy nl80211_policy[NL80211_ATTR_MAX+1] __read_mostly = {
>> [NL80211_ATTR_WIPHY] = { .type = NLA_U32 },
>> [NL80211_ATTR_WIPHY_NAME] = { .type = NLA_NUL_STRING,
>> - .len = BUS_ID_SIZE-1 },
>> + .len = 20-1 },
>> [NL80211_ATTR_WIPHY_TXQ_PARAMS] = { .type = NLA_NESTED },
>> [NL80211_ATTR_WIPHY_FREQ] = { .type = NLA_U32 },
>> [NL80211_ATTR_WIPHY_CHANNEL_TYPE] = { .type = NLA_U32 },
>
> this patch is actually wrong.
It cannot be right or wrong, it is merely replacing an existing value
with the constant equivalent. It is a change which does absolutely
nothing.
> You should remove the .len value all together since the phy name has
> no limit anymore and so shouldn't the netlink API.
Anyone is free to make that improvement. But that's now what
I am trying to accomplish here.
next prev parent reply other threads:[~2009-05-28 8:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-27 4:39 [PATCH 5/6]: nl80211: Eliminate reference to BUS_ID_SIZE David Miller
2009-05-28 7:27 ` Marcel Holtmann
2009-05-28 8:08 ` David Miller [this message]
2009-05-28 9:33 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090528.010830.45004716.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=greg@kroah.com \
--cc=johannes@sipsolutions.net \
--cc=kay.sievers@vrfy.org \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).