netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next-2.6] net: unset IFF_XMIT_DST_RELEASE in ipip_tunnel_setup()
@ 2009-05-28 20:44 Eric Dumazet
  2009-05-29  8:35 ` [PATCH net-next-2.6] net: unset IFF_XMIT_DST_RELEASE in ipgre_tunnel_setup() Eric Dumazet
  2009-05-29  8:47 ` [PATCH net-next-2.6] net: unset IFF_XMIT_DST_RELEASE in ipip_tunnel_setup() David Miller
  0 siblings, 2 replies; 4+ messages in thread
From: Eric Dumazet @ 2009-05-28 20:44 UTC (permalink / raw)
  To: David S. Miller; +Cc: Linux Netdev List

ipip_tunnel_xmit() might need skb->dst, so tell dev_hard_start_xmit()
to no release it.

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
---
diff --git a/net/ipv4/ipip.c b/net/ipv4/ipip.c
index 9054139..bb2f1b1 100644
--- a/net/ipv4/ipip.c
+++ b/net/ipv4/ipip.c
@@ -713,6 +713,7 @@ static void ipip_tunnel_setup(struct net_device *dev)
 	dev->iflink		= 0;
 	dev->addr_len		= 4;
 	dev->features		|= NETIF_F_NETNS_LOCAL;
+	dev->priv_flags		&= ~IFF_XMIT_DST_RELEASE;
 }
 
 static void ipip_tunnel_init(struct net_device *dev)

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH net-next-2.6] net: unset IFF_XMIT_DST_RELEASE in ipgre_tunnel_setup()
  2009-05-28 20:44 [PATCH net-next-2.6] net: unset IFF_XMIT_DST_RELEASE in ipip_tunnel_setup() Eric Dumazet
@ 2009-05-29  8:35 ` Eric Dumazet
  2009-05-29  8:47   ` David Miller
  2009-05-29  8:47 ` [PATCH net-next-2.6] net: unset IFF_XMIT_DST_RELEASE in ipip_tunnel_setup() David Miller
  1 sibling, 1 reply; 4+ messages in thread
From: Eric Dumazet @ 2009-05-29  8:35 UTC (permalink / raw)
  To: David S. Miller; +Cc: Linux Netdev List

ipgre_tunnel_xmit() might need skb->dst, so tell dev_hard_start_xmit()
to no release it.

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
---
diff --git a/net/ipv4/ip_gre.c b/net/ipv4/ip_gre.c
index e62510d..77436e2 100644
--- a/net/ipv4/ip_gre.c
+++ b/net/ipv4/ip_gre.c
@@ -1238,6 +1238,7 @@ static void ipgre_tunnel_setup(struct net_device *dev)
 	dev->iflink		= 0;
 	dev->addr_len		= 4;
 	dev->features		|= NETIF_F_NETNS_LOCAL;
+	dev->priv_flags		&= ~IFF_XMIT_DST_RELEASE;
 }
 
 static int ipgre_tunnel_init(struct net_device *dev)

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH net-next-2.6] net: unset IFF_XMIT_DST_RELEASE in ipip_tunnel_setup()
  2009-05-28 20:44 [PATCH net-next-2.6] net: unset IFF_XMIT_DST_RELEASE in ipip_tunnel_setup() Eric Dumazet
  2009-05-29  8:35 ` [PATCH net-next-2.6] net: unset IFF_XMIT_DST_RELEASE in ipgre_tunnel_setup() Eric Dumazet
@ 2009-05-29  8:47 ` David Miller
  1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2009-05-29  8:47 UTC (permalink / raw)
  To: eric.dumazet; +Cc: netdev

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 28 May 2009 22:44:30 +0200

> ipip_tunnel_xmit() might need skb->dst, so tell dev_hard_start_xmit()
> to no release it.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>

Applied.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH net-next-2.6] net: unset IFF_XMIT_DST_RELEASE in ipgre_tunnel_setup()
  2009-05-29  8:35 ` [PATCH net-next-2.6] net: unset IFF_XMIT_DST_RELEASE in ipgre_tunnel_setup() Eric Dumazet
@ 2009-05-29  8:47   ` David Miller
  0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2009-05-29  8:47 UTC (permalink / raw)
  To: eric.dumazet; +Cc: netdev

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 29 May 2009 10:35:10 +0200

> ipgre_tunnel_xmit() might need skb->dst, so tell dev_hard_start_xmit()
> to no release it.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>

Applied.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2009-05-29  8:47 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-28 20:44 [PATCH net-next-2.6] net: unset IFF_XMIT_DST_RELEASE in ipip_tunnel_setup() Eric Dumazet
2009-05-29  8:35 ` [PATCH net-next-2.6] net: unset IFF_XMIT_DST_RELEASE in ipgre_tunnel_setup() Eric Dumazet
2009-05-29  8:47   ` David Miller
2009-05-29  8:47 ` [PATCH net-next-2.6] net: unset IFF_XMIT_DST_RELEASE in ipip_tunnel_setup() David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).