From: David Miller <davem@davemloft.net>
To: divy@chelsio.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
swise@opengridcomputing.com
Subject: Re: [PATCH 2.6.30 1/2] cxgb3: fix dma mapping regression
Date: Fri, 29 May 2009 01:56:47 -0700 (PDT) [thread overview]
Message-ID: <20090529.015647.51443277.davem@davemloft.net> (raw)
In-Reply-To: <20090528212302.28149.46684.stgit@speedy5>
From: Divy Le Ray <divy@chelsio.com>
Date: Thu, 28 May 2009 14:23:02 -0700
> From: Divy Le Ray <divy@chelsio.com>
>
> Commit 5e68b772e6efd189d6aca76f6872fb75d51ace60
> cxgb3: map entire Rx page, feed map+offset to Rx ring.
>
> introduced a regression on platforms defining DECLARE_PCI_UNMAP_ADDR()
> and related macros as no-ops.
>
> Rx descriptors are fed with the a page buffer bus address + page chunk offset.
> The page buffer bus address is set and retrieved through
> pci_unamp_addr_set(), pci_unmap_addr().
> These functions being meaningless on x86 (if CONFIG_DMA_API_DEBUG is not set).
> The HW ends up with a bogus bus address.
>
> This patch saves the page buffer bus address for all plaftorms.
>
> Signed-off-by: Divy Le Ray <divy@chelsio.com>
Applied.
prev parent reply other threads:[~2009-05-29 8:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-28 21:23 [PATCH 2.6.30 1/2] cxgb3: fix dma mapping regression Divy Le Ray
2009-05-29 8:56 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090529.015647.51443277.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=divy@chelsio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).