From: David Miller <davem@davemloft.net>
To: vapier@gentoo.org
Cc: netdev@vger.kernel.org, uclinux-dist-devel@blackfin.uclinux.org,
sonic.zhang@analog.com, vapier.adi@gmail.com,
cooloney@kernel.org
Subject: Re: [PATCH 2/5] netdev: bfin_mac: fix malformed UDP packet transmission when polling with KGDB
Date: Fri, 29 May 2009 02:04:05 -0700 (PDT) [thread overview]
Message-ID: <20090529.020405.170805407.davem@davemloft.net> (raw)
In-Reply-To: <1243404615-25879-3-git-send-email-vapier@gentoo.org>
From: Mike Frysinger <vapier@gentoo.org>
Date: Wed, 27 May 2009 02:10:12 -0400
> From: Sonic Zhang <sonic.zhang@analog.com>
>
> Make sure data is really written into the registers before enabling DMA.
> Otherwise, the EMAC DMA controller may transfer out a malformed packet.
> This patch may also fix netperf bugs or scp bugs.
>
> Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
> Signed-off-by: Mike Frysinger <vapier.adi@gmail.com>
> Signed-off-by: Bryan Wu <cooloney@kernel.org>
Instead of using this incredibly non-portable blackfin specific SSYNC
thing, why not read back a register from the device to ensure the
register writes hit the chip just like other drivers do?
If that doesn't work, enhance your commit message to describe (in
detail) why SSYNC is the only way to make this work properly.
I'm not applying this as-is.
next prev parent reply other threads:[~2009-05-29 9:04 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-27 6:10 [PATCH 0/5] Blackfin MAC updates for 2.6.31 Mike Frysinger
2009-05-27 6:10 ` [PATCH 1/5] netdev: bfin_mac: Blackfin EMAC interrupt may not be shared Mike Frysinger
2009-05-29 9:01 ` David Miller
2009-05-29 10:49 ` [Uclinux-dist-devel] " Mike Frysinger
2009-05-29 10:53 ` David Miller
2009-05-29 11:12 ` Hennerich, Michael
2009-05-29 11:14 ` David Miller
2009-05-29 11:22 ` Mike Frysinger
2009-05-29 11:28 ` David Miller
2009-05-29 11:45 ` Mike Frysinger
2009-05-29 22:09 ` David Miller
2009-05-29 22:13 ` Mike Frysinger
2009-05-29 22:18 ` David Miller
2009-05-29 22:21 ` Mike Frysinger
2009-05-29 22:45 ` David Miller
2009-05-29 22:51 ` Mike Frysinger
2009-05-29 13:39 ` [PATCH 1/4 v2] netdev: bfin_mac: drop useless IRQF_SHARED from Blackfin EMAC interrupt Mike Frysinger
2009-05-29 22:49 ` David Miller
2009-05-27 6:10 ` [PATCH 2/5] netdev: bfin_mac: fix malformed UDP packet transmission when polling with KGDB Mike Frysinger
2009-05-29 9:04 ` David Miller [this message]
2009-05-29 10:46 ` Mike Frysinger
2009-05-29 10:52 ` David Miller
2009-05-29 11:20 ` Mike Frysinger
2009-05-29 11:27 ` David Miller
2009-05-29 11:42 ` Mike Frysinger
2009-05-31 2:42 ` Zhang, Sonic
2009-05-31 2:45 ` Zhang, Sonic
2009-05-29 13:40 ` [PATCH 2/4 v2] " Mike Frysinger
2009-05-29 22:49 ` David Miller
2009-05-31 2:57 ` Zhang, Sonic
2009-05-27 6:10 ` [PATCH 3/5] netdev: bfin_mac: fix performance issue found by netperf Mike Frysinger
2009-05-29 9:05 ` David Miller
2009-05-29 13:41 ` [PATCH 3/4 v2] " Mike Frysinger
2009-05-29 22:49 ` David Miller
2009-05-27 6:10 ` [PATCH 4/5] netdev: bfin_mac: add Blackfin MII bus to platform bus to allow DSA access Mike Frysinger
2009-05-29 9:09 ` David Miller
2009-05-27 6:10 ` [PATCH 5/5] netdev: bfin_mac: fix crash when unloading module Mike Frysinger
2009-05-29 9:10 ` David Miller
2009-05-29 11:47 ` [Uclinux-dist-devel] " Mike Frysinger
2009-05-29 13:41 ` [PATCH 4/4 v2] netdev: bfin_mac: add Blackfin MII bus to platform bus to allow DSA access Mike Frysinger
2009-05-29 22:49 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090529.020405.170805407.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cooloney@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sonic.zhang@analog.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=vapier.adi@gmail.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).