netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mac8390: use printk MAC address format
       [not found] <Pine.LNX.4.64.0905260136450.18180@loopy.telegraphics.com.au>
@ 2009-05-26  2:52 ` Finn Thain
  2009-05-30  5:14   ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Finn Thain @ 2009-05-26  2:52 UTC (permalink / raw)
  To: David S. Miller; +Cc: linux-m68k, netdev


mac8390: use printk MAC address format

Signed-off-by: Finn Thain <fthain@telegraphics.com.au>

---

Resending with netdev list CC'd as requested.


--- linux-2.6.29.orig/drivers/net/mac8390.c	2009-03-24 10:12:14.000000000 +1100
+++ linux-2.6.29/drivers/net/mac8390.c	2009-05-22 01:48:07.000000000 +1000
@@ -620,19 +620,12 @@
 
 	/* Good, done, now spit out some messages */
 	printk(KERN_INFO "%s: %s in slot %X (type %s)\n",
-		   dev->name, ndev->board->name, ndev->board->slot, cardname[type]);
-	printk(KERN_INFO "MAC ");
-	{
-		int i;
-		for (i = 0; i < 6; i++) {
-			printk("%2.2x", dev->dev_addr[i]);
-			if (i < 5)
-				printk(":");
-		}
-	}
-	printk(" IRQ %d, %d KB shared memory at %#lx,  %d-bit access.\n",
-		   dev->irq, (int)((dev->mem_end - dev->mem_start)/0x1000) * 4,
-		   dev->mem_start, access_bitmode?32:16);
+	       dev->name, ndev->board->name, ndev->board->slot, cardname[type]);
+	printk(KERN_INFO
+	       "MAC %pM IRQ %d, %d KB shared memory at %#lx, %d-bit access.\n",
+	       dev->dev_addr, dev->irq,
+	       (unsigned int)(dev->mem_end - dev->mem_start) >> 10,
+	       dev->mem_start, access_bitmode ? 32 : 16);
 	return 0;
 }
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] mac8390: use printk MAC address format
  2009-05-26  2:52 ` [PATCH] mac8390: use printk MAC address format Finn Thain
@ 2009-05-30  5:14   ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-05-30  5:14 UTC (permalink / raw)
  To: fthain; +Cc: linux-m68k, netdev

From: Finn Thain <fthain@telegraphics.com.au>
Date: Tue, 26 May 2009 12:52:47 +1000 (EST)

> 
> mac8390: use printk MAC address format
> 
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>

Applied to net-next-2.6, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-05-30  5:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <Pine.LNX.4.64.0905260136450.18180@loopy.telegraphics.com.au>
2009-05-26  2:52 ` [PATCH] mac8390: use printk MAC address format Finn Thain
2009-05-30  5:14   ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).