From: David Miller <davem@davemloft.net>
To: jpirko@redhat.com
Cc: netdev@vger.kernel.org, jeffrey.t.kirsher@intel.com,
jesse.brandeburg@intel.com, bruce.w.allan@intel.com,
peter.p.waskiewicz.jr@intel.com, john.ronciak@intel.com
Subject: Re: [PATCH net-next] net: convert unicast addr list
Date: Fri, 29 May 2009 22:15:28 -0700 (PDT) [thread overview]
Message-ID: <20090529.221528.251215500.davem@davemloft.net> (raw)
In-Reply-To: <20090523092215.GA3386@psychotron.englab.brq.redhat.com>
From: Jiri Pirko <jpirko@redhat.com>
Date: Sat, 23 May 2009 11:22:17 +0200
> [PATCH net-next] net: convert unicast addr list
>
> This patch converts unicast address list to standard list_head using previously
> introduced struct netdev_hw_addr. It also relaxes the locking. Original spinlock
> (still used for multicast addresses) is not needed and is no longer used for a
> protection of this list. All reading and writing takes place under rtnl (with no
> changes).
>
> I also removed a possibility to specify the length of the address while adding
> or deleting unicast address. It's always dev->addr_len.
>
> The convertion touched especially e1000 and ixgbe codes when the change is not
> so trivial.
>
> Signed-off-by: Jiri Pirko <jpirko@redhat.com>
Even though this touches some drivers non-trivially I like the
change a lot and driver folks have had multiple days to look
this over and say "hold off" if there were any major objections
and they didn't.
So applied to net-next-2.6, thanks!
prev parent reply other threads:[~2009-05-30 5:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-23 9:22 [PATCH net-next] net: convert unicast addr list Jiri Pirko
2009-05-30 5:15 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090529.221528.251215500.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bruce.w.allan@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=jpirko@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).