netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 2/10]: wavelan: Remove bogus debugging on skb->next being non-NULL.
@ 2009-05-29  8:40 David Miller
  2009-05-29 10:17 ` John W. Linville
  0 siblings, 1 reply; 2+ messages in thread
From: David Miller @ 2009-05-29  8:40 UTC (permalink / raw)
  To: netdev; +Cc: linux-wireless

From: David Miller <davem@davemloft.net>
Fcc: +backup
X-Mailer: Mew version 6.2.51 on Emacs 22.1 / Mule 5.0 (SAKAKI)
----

This eliminates explicit references to the SKB list handling
implementation.

Signed-off-by: David S. Miller <davem@davemloft.net>
---
 drivers/net/wireless/wavelan.c    |    4 ----
 drivers/net/wireless/wavelan_cs.c |    5 -----
 2 files changed, 0 insertions(+), 9 deletions(-)

diff --git a/drivers/net/wireless/wavelan.c b/drivers/net/wireless/wavelan.c
index 3ab3eb9..25d27b6 100644
--- a/drivers/net/wireless/wavelan.c
+++ b/drivers/net/wireless/wavelan.c
@@ -2869,10 +2869,6 @@ static int wavelan_packet_xmit(struct sk_buff *skb, struct net_device * dev)
 		if (lp->tx_n_in_use == (NTXBLOCKS - 1))
 			return 1;
 	}
-#ifdef DEBUG_TX_ERROR
-	if (skb->next)
-		printk(KERN_INFO "skb has next\n");
-#endif
 
 	/* Do we need some padding? */
 	/* Note : on wireless the propagation time is in the order of 1us,
diff --git a/drivers/net/wireless/wavelan_cs.c b/drivers/net/wireless/wavelan_cs.c
index e55b339..1a90d69 100644
--- a/drivers/net/wireless/wavelan_cs.c
+++ b/drivers/net/wireless/wavelan_cs.c
@@ -3107,11 +3107,6 @@ wavelan_packet_xmit(struct sk_buff *	skb,
        * so the Tx buffer is now free */
     }
 
-#ifdef DEBUG_TX_ERROR
-	if (skb->next)
-		printk(KERN_INFO "skb has next\n");
-#endif
-
 	/* Check if we need some padding */
 	/* Note : on wireless the propagation time is in the order of 1us,
 	 * and we don't have the Ethernet specific requirement of beeing
-- 
1.6.3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 2/10]: wavelan: Remove bogus debugging on skb->next being non-NULL.
  2009-05-29  8:40 [PATCH 2/10]: wavelan: Remove bogus debugging on skb->next being non-NULL David Miller
@ 2009-05-29 10:17 ` John W. Linville
  0 siblings, 0 replies; 2+ messages in thread
From: John W. Linville @ 2009-05-29 10:17 UTC (permalink / raw)
  To: David Miller; +Cc: netdev, linux-wireless

On Fri, May 29, 2009 at 01:40:02AM -0700, David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Fcc: +backup
> X-Mailer: Mew version 6.2.51 on Emacs 22.1 / Mule 5.0 (SAKAKI)
> ----
> 
> This eliminates explicit references to the SKB list handling
> implementation.
> 
> Signed-off-by: David S. Miller <davem@davemloft.net>

ACK

-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-05-29 10:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-29  8:40 [PATCH 2/10]: wavelan: Remove bogus debugging on skb->next being non-NULL David Miller
2009-05-29 10:17 ` John W. Linville

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).