From: Jiri Pirko <jpirko@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: fthain@telegraphics.com.au, netdev@vger.kernel.org,
linux-m68k@vger.kernel.org, geert.uytterhoeven@gmail.com,
shemminger@vyatta.com
Subject: Re: [PATCH] mac8390: fix build with NET_POLL_CONTROLLER
Date: Fri, 29 May 2009 14:03:58 +0200 [thread overview]
Message-ID: <20090529120357.GC3492@psychotron.englab.brq.redhat.com> (raw)
In-Reply-To: <20090529.015608.21828664.davem@davemloft.net>
Fri, May 29, 2009 at 10:56:08AM CEST, davem@davemloft.net wrote:
>From: Finn Thain <fthain@telegraphics.com.au>
>Date: Thu, 28 May 2009 22:05:53 +1000 (EST)
>
>> --- linux-2.6.29.orig/drivers/net/Makefile 2009-05-28 15:15:13.000000000 +1000
>> +++ linux-2.6.29/drivers/net/Makefile 2009-05-28 15:15:54.000000000 +1000
>> @@ -489,7 +489,7 @@
>> .ndo_set_mac_address = eth_mac_addr,
>> .ndo_change_mtu = eth_change_mtu,
>> #ifdef CONFIG_NET_POLL_CONTROLLER
>> - .ndo_poll_controller = ei_poll,
>> + .ndo_poll_controller = __ei_poll,
>> #endif
>> };
>
>I don't think this is a patch to drivers/net/Makefile :-)
:)) Good one.. I wonder how this can happen ;)
>
>I've seen some patch screwups in my time, but this one
>takes the cake as one of the most impressive ones :-)
>
>I'll fix it up by hand, but realize that this makes more
>work for me.
>--
>To unsubscribe from this list: send the line "unsubscribe netdev" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-05-29 12:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.64.0905260116120.18180@loopy.telegraphics.com.au>
2009-05-26 2:50 ` [PATCH] mac8390: fix regression caused during net_device_ops conversion Finn Thain
2009-05-26 5:44 ` David Miller
[not found] ` <10f740e80905270149q2b906d53u8bf71b7d382a57a3@mail.gmail.com>
2009-05-28 5:26 ` [PATCH] mac8390: fix regression caused during net_device_ops conversion, take 2 Finn Thain
2009-05-28 5:33 ` David Miller
2009-05-28 12:05 ` [PATCH] mac8390: fix build with NET_POLL_CONTROLLER Finn Thain
2009-05-29 8:56 ` David Miller
2009-05-29 12:03 ` Jiri Pirko [this message]
2009-05-29 15:25 ` Finn Thain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090529120357.GC3492@psychotron.englab.brq.redhat.com \
--to=jpirko@redhat.com \
--cc=davem@davemloft.net \
--cc=fthain@telegraphics.com.au \
--cc=geert.uytterhoeven@gmail.com \
--cc=linux-m68k@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).