From: Jarek Poplawski <jarkao2@gmail.com>
To: jamal <hadi@cyberus.ca>
Cc: Minoru Usui <mi.usui@gmail.com>,
Minoru Usui <usui@mxm.nes.nec.co.jp>,
netdev@vger.kernel.org, containers@lists.linux-foundation.org
Subject: Re: [BUG] net_cls: Panic occured when net_cls subsystem use
Date: Sat, 30 May 2009 15:20:47 +0200 [thread overview]
Message-ID: <20090530132047.GD3166@ami.dom.local> (raw)
In-Reply-To: <1243688628.3966.126.camel@dogo.mojatatu.com>
On Sat, May 30, 2009 at 09:03:48AM -0400, jamal wrote:
> On Sat, 2009-05-30 at 14:45 +0200, Jarek Poplawski wrote:
> > On Sat, May 30, 2009 at 08:31:23AM -0400, jamal wrote:
...
> > > The ops is caused by the code fixed in the patch - did i miss something?
> >
> > IMHO it could be fixed "old way" in cls_group code too.
>
> Is the code oopsing in cls_group? It didnt seem to be so to me, and
> yes cls_group is quarky in its practise (but thats a separate issue)
> and even if it did oops in cls_group - this change above is a memory
> leak and needs to be fixed in -stable.
Yes it oopses in cls_cgroup_classify(). Here is the first report:
http://permalink.gmane.org/gmane.linux.network/128593
We add/link unconfigured tp, but it could be destroyed later, so I
wouldn't call this a memory leak.
Cheers,
Jarek P.
next prev parent reply other threads:[~2009-05-30 13:20 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-21 0:22 [BUG] net_cls: Panic occured when net_cls subsystem use Minoru Usui
2009-05-29 5:18 ` Minoru Usui
2009-05-29 7:48 ` Jarek Poplawski
2009-05-29 8:03 ` Jarek Poplawski
2009-05-29 10:22 ` Jarek Poplawski
[not found] ` <20090529102232.GA6279-8HppEYmqbBCE+EvaaNYduQ@public.gmane.org>
2009-05-29 13:15 ` jamal
2009-05-29 13:46 ` jamal
2009-05-29 13:54 ` jamal
2009-05-29 22:59 ` Jarek Poplawski
[not found] ` <20090529225929.GD2753-dUp/P3zyUuaNj9Bq2fkWzw@public.gmane.org>
2009-05-30 11:17 ` Minoru Usui
2009-05-30 11:45 ` Jarek Poplawski
2009-05-30 11:56 ` jamal
[not found] ` <1243684594.3966.89.camel-A00voryUPPswpNmlq7E/ZAC/G2K4zDHf@public.gmane.org>
2009-05-30 12:07 ` Jarek Poplawski
[not found] ` <20090530120750.GB3166-dUp/P3zyUuaNj9Bq2fkWzw@public.gmane.org>
2009-05-30 12:31 ` jamal
2009-05-30 12:45 ` Jarek Poplawski
2009-05-30 13:03 ` jamal
2009-05-30 13:20 ` Jarek Poplawski [this message]
2009-05-30 13:31 ` jamal
2009-05-30 14:00 ` Jarek Poplawski
[not found] ` <20090530140006.GE3166-dUp/P3zyUuaNj9Bq2fkWzw@public.gmane.org>
2009-05-30 22:38 ` Minoru Usui
2009-05-30 23:34 ` jamal
2009-05-31 1:45 ` Minoru Usui
2009-05-31 8:15 ` Jarek Poplawski
2009-05-30 23:08 ` jamal
[not found] ` <1243724933.3966.158.camel-A00voryUPPswpNmlq7E/ZAC/G2K4zDHf@public.gmane.org>
2009-05-31 7:55 ` Jarek Poplawski
2009-05-31 13:17 ` jamal
2009-05-31 20:33 ` Jarek Poplawski
2009-05-30 22:22 ` Minoru Usui
2009-05-30 23:13 ` jamal
2009-05-31 8:07 ` Jarek Poplawski
2009-05-30 11:50 ` jamal
2009-05-31 8:12 ` Jarek Poplawski
2009-05-31 13:24 ` jamal
2009-05-31 13:43 ` jamal
[not found] ` <1243777427.3966.243.camel-A00voryUPPswpNmlq7E/ZAC/G2K4zDHf@public.gmane.org>
2009-05-31 21:12 ` Jarek Poplawski
2009-05-31 19:55 ` Jarek Poplawski
[not found] ` <20090531195557.GA2777-dUp/P3zyUuaNj9Bq2fkWzw@public.gmane.org>
2009-05-31 23:40 ` jamal
2009-06-01 6:06 ` Jarek Poplawski
2009-06-01 13:03 ` jamal
2009-06-01 13:34 ` Minoru Usui
2009-06-01 20:49 ` Jarek Poplawski
2009-06-01 21:55 ` Jarek Poplawski
2009-06-01 22:06 ` jamal
[not found] ` <1243893963.3966.325.camel-A00voryUPPswpNmlq7E/ZAC/G2K4zDHf@public.gmane.org>
2009-06-02 6:26 ` Jarek Poplawski
2009-06-02 13:16 ` jamal
2009-06-02 21:10 ` Jarek Poplawski
2009-06-03 11:27 ` Jarek Poplawski
2009-06-10 11:58 ` jamal
2009-06-02 6:59 ` Minoru Usui
2009-06-02 7:24 ` Jarek Poplawski
2009-06-02 8:29 ` Minoru Usui
[not found] ` <20090602155919.da89c08e.usui-vEbCzmPPqHe45+QrQBaojngSJqDPrsil@public.gmane.org>
2009-06-02 13:19 ` jamal
2009-06-04 4:41 ` Minoru Usui
2009-06-04 6:34 ` Jarek Poplawski
2009-06-04 8:37 ` Jarek Poplawski
2009-06-01 5:25 ` Minoru Usui
2009-06-01 9:12 ` Minoru Usui
2009-06-08 6:39 ` Minoru Usui
2009-06-08 7:48 ` Jarek Poplawski
2009-06-09 0:02 ` Minoru Usui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090530132047.GD3166@ami.dom.local \
--to=jarkao2@gmail.com \
--cc=containers@lists.linux-foundation.org \
--cc=hadi@cyberus.ca \
--cc=mi.usui@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=usui@mxm.nes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).