From: David Miller <davem@davemloft.net>
To: jie.yang@atheros.com
Cc: pyunyh@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next]atl1c: fix spelling error
Date: Sun, 31 May 2009 21:51:40 -0700 (PDT) [thread overview]
Message-ID: <20090531.215140.214511212.davem@davemloft.net> (raw)
In-Reply-To: <12438220782521-git-send-email-jie.yang@atheros.com>
From: <jie.yang@atheros.com>
Date: Mon, 1 Jun 2009 10:07:58 +0800
> Fix spelling error
>
> Signed-off-by: Jie Yang <jie.yang@atheros.com>
...
> @@ -1115,7 +1115,7 @@ static int atl1c_stop_mac(struct atl1c_hw *hw)
>
> AT_READ_REG(hw, REG_TXQ_CTRL, &data);
> data &= ~TXQ_CTRL_EN;
> - AT_WRITE_REG(hw, REG_TWSI_CTRL, data);
> + AT_WRITE_REG(hw, REG_TXQ_CTRL, data);
>
> for (timeout = 0; timeout < AT_HW_MAX_IDLE_DELAY; timeout++) {
> AT_READ_REG(hw, REG_IDLE_STATUS, &data);
A spelling error would occur on human language text.
That's not what this is.
The code is referring to the wrong register, so it's a bug not a
spelling error.
Please fix your commit message and resubmit.
prev parent reply other threads:[~2009-06-01 4:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-01 2:07 [PATCH net-next]atl1c: fix spelling error jie.yang
2009-06-01 4:51 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090531.215140.214511212.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jie.yang@atheros.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pyunyh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).