From: David Miller <davem@davemloft.net>
To: tilman@imap.cc
Cc: karsten-keil@t-online.de, isdn4linux@listserv.isdn4linux.de,
i4ldeveloper@listserv.isdn4linux.de, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] isdn: patches for 2.6.31
Date: Mon, 01 Jun 2009 03:04:34 -0700 (PDT) [thread overview]
Message-ID: <20090601.030434.141357758.davem@davemloft.net> (raw)
In-Reply-To: <20090531-patch-00.tilman@imap.cc>
From: Tilman Schmidt <tilman@imap.cc>
Date: Sun, 31 May 2009 01:32:04 +0200 (CEST)
> I would like to propose the following three patches to the Kernel CAPI
> subsystem for inclusion in kernel release 2.6.31.
> The first one was proposed four weeks ago and so far hasn't met any
> protests.
> The second one is a rather trivial bugfix and documentation improvement.
> The third one just adds a few new insights about the workings of the
> CAPI subsystem to the Documentation file, INTERFACE.CAPI.
I'm not applying this patch series.
Especially I dislike the second patch.
First problem in the second patch. You're doing two things
at once. You're adding function documentation and also adding
a NULL pointer check.
Second problem, the NULL pointer check is gratuitous. Document
that the 'm' member has to be non-NULL and leave the check out.
Thanks.
next prev parent reply other threads:[~2009-06-01 10:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-30 23:32 [PATCH 0/3] isdn: patches for 2.6.31 Tilman Schmidt
2009-05-30 23:32 ` [PATCH 1/3] isdn: rename capi_ctr_reseted() to capi_ctr_down() Tilman Schmidt
2009-05-31 5:19 ` Marcel Holtmann
2009-05-30 23:32 ` [PATCH 2/3] isdn: prevent NULL ptr oops in capi_cmsg2str() Tilman Schmidt
2009-05-30 23:32 ` [PATCH 3/3] isdn: extend INTERFACE.CAPI document Tilman Schmidt
2009-06-01 10:04 ` David Miller [this message]
2009-06-06 22:38 ` [PATCH 0/3] isdn: patches for 2.6.31 Tilman Schmidt
2009-06-07 11:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090601.030434.141357758.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=i4ldeveloper@listserv.isdn4linux.de \
--cc=isdn4linux@listserv.isdn4linux.de \
--cc=karsten-keil@t-online.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tilman@imap.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).