netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: dada1@cosmosbay.com
Cc: nicolas.dichtel@dev.6wind.com, netdev@vger.kernel.org
Subject: Re: [PATCH] ipv4/ipv6: check hop limit field on input
Date: Mon, 01 Jun 2009 22:43:30 -0700 (PDT)	[thread overview]
Message-ID: <20090601.224330.267938162.davem@davemloft.net> (raw)
In-Reply-To: <4A24B920.2010605@cosmosbay.com>

From: Eric Dumazet <dada1@cosmosbay.com>
Date: Tue, 02 Jun 2009 07:31:12 +0200

> David Miller a écrit :
>> From: Nicolas Dichtel <nicolas.dichtel@dev.6wind.com>
>> Date: Mon, 01 Jun 2009 17:13:43 +0200
>> 
>>> RFC indicates that a router must drop the packet if this field is 0.
>> 
>> It only must do this when executing the forwarding function.  It's an
>> egress check, not an ingress one.
>> 
>> I'm not applying this patch, it can even break some applications
>> out there that use a TTL of zero intentionally to keep traffic
>> only on a local subnet.
> 
> I wonder if we then should allow setting ttl to zero. I had to patch
> my kernel to allow ping to do this...
> 
> I'll check RFC when time permits.

Eric, notice how I mentioned in my other reply to this thread
"multicast" applications, which use mc_ttl which we allow to be set to
zero.

  reply	other threads:[~2009-06-02  5:43 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-01 15:13 [PATCH] ipv4/ipv6: check hop limit field on input Nicolas Dichtel
2009-06-01 16:19 ` Florian Westphal
2009-06-01 16:49   ` Nicolas Dichtel
2009-06-01 17:13     ` Florian Westphal
2009-06-02  9:30       ` Nicolas Dichtel
2009-06-01 18:43     ` Eric Dumazet
2009-06-01 18:55       ` Brian Haley
2009-06-02  1:54         ` John Dykstra
2009-06-02  2:02           ` David Miller
2009-06-02  9:22             ` John Dykstra
2009-06-02  9:32               ` David Miller
2009-06-02  9:35           ` Nicolas Dichtel
2009-06-02  9:30         ` Nicolas Dichtel
2009-06-02  9:30       ` Nicolas Dichtel
2009-06-02  2:04 ` David Miller
2009-06-02  5:31   ` Eric Dumazet
2009-06-02  5:43     ` David Miller [this message]
2009-06-02  9:36   ` Nicolas Dichtel
2009-06-02  9:37     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090601.224330.267938162.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dada1@cosmosbay.com \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.dichtel@dev.6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).