From: David Miller <davem@davemloft.net>
To: eswierk@aristanetworks.com
Cc: netdev@vger.kernel.org, aabdulla@nvidia.com
Subject: Re: [PATCH] forcedeth: add phy_power_down parameter, leave phy powered up by default (v2)
Date: Tue, 02 Jun 2009 00:19:59 -0700 (PDT) [thread overview]
Message-ID: <20090602.001959.08867168.davem@davemloft.net> (raw)
In-Reply-To: <1243864477.13996.23.camel@localhost.localdomain>
From: Ed Swierk <eswierk@aristanetworks.com>
Date: Mon, 01 Jun 2009 06:54:37 -0700
> Add a phy_power_down parameter to forcedeth: set to 1 to power down the
> phy and disable the link when an interface goes down; set to 0 to always
> leave the phy powered up.
>
> The phy power state persists across reboots; Windows, some BIOSes, and
> older versions of Linux don't bother to power up the phy again, forcing
> users to remove all power to get the interface working (see
> http://bugzilla.kernel.org/show_bug.cgi?id=13072). Leaving the phy
> powered on is the safest default behavior. Users accustomed to seeing
> the link state reflect the interface state and/or wanting to minimize
> power consumption can set phy_power_down=1 if compatibility with other
> OSes is not an issue.
>
> Signed-off-by: Ed Swierk <eswierk@aristanetworks.com>
Applied, thanks Ed.
prev parent reply other threads:[~2009-06-02 7:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-01 13:54 [PATCH] forcedeth: add phy_power_down parameter, leave phy powered up by default (v2) Ed Swierk
2009-06-02 7:19 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090602.001959.08867168.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aabdulla@nvidia.com \
--cc=eswierk@aristanetworks.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).