From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 0/4] net: define accessors to get/set skb->dst and skb->rtable
Date: Wed, 03 Jun 2009 03:35:21 -0700 (PDT) [thread overview]
Message-ID: <20090603.033521.215812392.davem@davemloft.net> (raw)
In-Reply-To: <4A25414D.6040605@gmail.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 02 Jun 2009 17:12:13 +0200
> Here are patches I originally cooked to review all places that could need skb->dst
>
> I believe they could be applied in net-next-2.6 because we could then
> implement what we discussed in last december, about avoiding
> refcounting on dst_entries in input path (thread about IP_PKTINFO stuff,
> and a patch we had to revert)
>
> You suggested to use the low order bit of skb->dst to tell if we got a
> refcount or not.
>
> These four patches implement grounding for this idea (no functional changes yet)
>
> Next step is adding the low order bit handling (or another bit if it happens
> to be too expensive to check this bit each time we want skb->dst, we
> still have to benchmark this)
It all looks great, applied, thanks Eric!
prev parent reply other threads:[~2009-06-03 10:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-02 15:12 [PATCH 0/4] net: define accessors to get/set skb->dst and skb->rtable Eric Dumazet
2009-06-03 10:35 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090603.033521.215812392.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).