From: David Miller <davem@davemloft.net>
To: akpm@linux-foundation.org
Cc: aabdulla@nvidia.com, manfred@colorfullife.com, netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] forcedeth: Addition of new device id
Date: Wed, 03 Jun 2009 14:57:21 -0700 (PDT) [thread overview]
Message-ID: <20090603.145721.65051603.davem@davemloft.net> (raw)
In-Reply-To: <20090603145238.fd4ece19.akpm@linux-foundation.org>
From: Andrew Morton <akpm@linux-foundation.org>
Date: Wed, 3 Jun 2009 14:52:38 -0700
> On Wed, 03 Jun 2009 14:26:47 -0700 (PDT)
> David Miller <davem@davemloft.net> wrote:
>
>> Andrew, we do not add new entries to pci_ids.h any more.
>
> Lots of people are still changing it.
Not enough policing, that's all. Even I let one slip in recently, but
that was an oversight rather than something I did on purpose. :-)
> I believe that the approach we've been taking is: if the driver
> presently uses pci_ids.h and you're adding a new ID then go for it.
> But new drivers should use a private site for the IDs. And patches
> which switch old drivers from pci_ids over to a private site are
> approved of.
I think it's silly to let use continue even in those situations. If
it's in a header file, it's so that it can (at least potentially) be
used in multiple places. That is not the situation we are handling
here, such defines are always used in exactly one place, the driver ID
table.
prev parent reply other threads:[~2009-06-03 21:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-02 19:18 [PATCH 2/2] forcedeth: Addition of new device id Ayaz Abdulla
2009-06-03 20:25 ` Andrew Morton
2009-06-03 21:26 ` David Miller
2009-06-03 21:52 ` Andrew Morton
2009-06-03 21:57 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090603.145721.65051603.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aabdulla@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=manfred@colorfullife.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).