From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: netdev@vger.kernel.org
Subject: Re: gso: Stop fraglists from escaping
Date: Wed, 03 Jun 2009 21:21:05 -0700 (PDT) [thread overview]
Message-ID: <20090603.212105.160757852.davem@davemloft.net> (raw)
In-Reply-To: <20090604010121.GA22871@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Thu, 4 Jun 2009 11:01:21 +1000
> gso: Stop fraglists from escaping
>
> As it stands skb fraglists can get past the check in dev_queue_xmit
> if the skb is marked as GSO. In particular, if the packet doesn't
> have the proper checksums for GSO, but can otherwise be handled by
> the underlying device, we will not perform the fraglist check on it
> at all.
>
> If the underlying device cannot handle fraglists, then this will
> break.
>
> The fix is as simple as moving the fraglist check from the device
> check into skb_gso_ok.
>
> This has caused crashes with Xen when used together with GRO which
> can generate GSO packets with fraglists.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Applied to net-next-2.6, thanks Herbert.
prev parent reply other threads:[~2009-06-04 4:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-04 1:01 gso: Stop fraglists from escaping Herbert Xu
2009-06-04 4:21 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090603.212105.160757852.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).