netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Riccardo Ghetta <birrachiara@tin.it>
To: netdev@vger.kernel.org
Subject: [PATCH 3/3] sis190: better message on unknown PHY
Date: Tue, 2 Jun 2009 09:53:37 +0000 (UTC)
Date: Wed, 3 Jun 2009 11:53:54 +0200	[thread overview]
Message-ID: <20090603095354.GA15649@localhost> (raw)
In-Reply-To: <cover.1244012631.git.birrachiara@tin.it>

Signed-off-by: Riccardo Ghetta <birrachiara@tin.it>
---
 drivers/net/sis190.c |   15 +++++++++------
 1 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/drivers/net/sis190.c b/drivers/net/sis190.c
index 8322e28..a69f3d2 100644
--- a/drivers/net/sis190.c
+++ b/drivers/net/sis190.c
@@ -348,7 +348,7 @@ static struct {
 	u32 msg_enable;
 } debug = { -1 };
 
-MODULE_DESCRIPTION("SiS sis190 Gigabit Ethernet driver");
+MODULE_DESCRIPTION("SiS sis190/191 Gigabit Ethernet driver");
 module_param(rx_copybreak, int, 0);
 MODULE_PARM_DESC(rx_copybreak, "Copy breakpoint for copy-only-tiny-frames");
 module_param_named(debug, debug.msg_enable, int, 0);
@@ -1329,12 +1329,15 @@ static void sis190_init_phy(struct net_device *dev, struct sis190_private *tp,
 			((mii_status & (BMSR_100FULL | BMSR_100HALF)) ?
 				LAN : HOME) : p->type;
 		tp->features |= p->feature;
-	} else
+		net_probe(tp, KERN_INFO "%s: %s transceiver at address %d.\n",
+			pci_name(tp->pci_dev), p->name, phy_id);
+	} else {
 		phy->type = UNKNOWN;
-
-	net_probe(tp, KERN_INFO "%s: %s transceiver at address %d.\n",
-		  pci_name(tp->pci_dev),
-		  (phy->type == UNKNOWN) ? "Unknown PHY" : p->name, phy_id);
+		net_probe(tp, KERN_INFO
+			"%s: unknown PHY 0x%x:0x%x transceiver at address %d\n",
+			pci_name(tp->pci_dev),
+			phy->id[0], (phy->id[1] & 0xfff0), phy_id);
+	}
 }
 
 static void sis190_mii_probe_88e1111_fixup(struct sis190_private *tp)
-- 
1.6.2.4


  parent reply	other threads:[~2009-06-02  9:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-03  8:49 [PATCH 0/3] sis190 gigabit fixes(bug 9735,11149) and new phy Riccardo Ghetta
2009-06-02  9:52 ` [PATCH 1/3] sis190: add new phy found on asus F5 series laptops Riccardo Ghetta
2009-06-02 21:18   ` Francois Romieu
2009-06-03  6:10     ` rgh
2009-06-04  4:41   ` David Miller
2009-06-02  9:52 ` [PATCH 2/3] sis190: fix gigabit negotiation Riccardo Ghetta
2009-06-02 21:38   ` Francois Romieu
2009-06-03  6:15     ` rgh
2009-06-02  9:53 ` Riccardo Ghetta [this message]
2009-06-02 21:43   ` [PATCH 3/3] sis190: better message on unknown PHY Francois Romieu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090603095354.GA15649@localhost \
    --to=birrachiara@tin.it \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).