From: Florian Fainelli <florian@openwrt.org>
To: "Richard R?öjfors" <richard.rojfors.ext@mocean-labs.com>
Cc: Jiri Pirko <jpirko@redhat.com>, netdev@vger.kernel.org
Subject: Re: [PATCH] netdev: Added KS8842 driver
Date: Wed, 3 Jun 2009 10:38:46 +0200 [thread overview]
Message-ID: <200906031038.47050.florian@openwrt.org> (raw)
In-Reply-To: <4A25831A.7010003@mocean-labs.com>
Le Tuesday 02 June 2009 21:52:58 Richard R?öjfors, vous avez écrit :
> Jiri Pirko wrote:
> >> +config KS8842
> >> + tristate "Micrel KSZ8842"
> >> + depends on PCI
> >
> > Why does this driver depend on PCI ?
>
> Good question.
> The KS8842 switch is actually behind an FPGA connected via PCIe,
> the next version of the FPGA firmware will have DMA support and the driver
> will depend on PCI. Is it worth removing the dependency for now?
You are not using any pci_* functions so I guess you can remove that
dependency for now.
--
Best regards, Florian Fainelli
Email : florian@openwrt.org
http://openwrt.org
-------------------------------
prev parent reply other threads:[~2009-06-03 8:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-02 18:50 [PATCH] netdev: Added KS8842 driver Richard Ršöjfors
2009-06-02 19:11 ` Jiri Pirko
2009-06-02 19:52 ` Richard R?öjfors
2009-06-03 8:38 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906031038.47050.florian@openwrt.org \
--to=florian@openwrt.org \
--cc=jpirko@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=richard.rojfors.ext@mocean-labs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).