From: Andrew Morton <akpm@linux-foundation.org>
To: David Miller <davem@davemloft.net>
Cc: aabdulla@nvidia.com, manfred@colorfullife.com, netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] forcedeth: Addition of new device id
Date: Wed, 3 Jun 2009 14:52:38 -0700 [thread overview]
Message-ID: <20090603145238.fd4ece19.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090603.142647.149845259.davem@davemloft.net>
On Wed, 03 Jun 2009 14:26:47 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:
> From: Andrew Morton <akpm@linux-foundation.org>
> Date: Wed, 3 Jun 2009 13:25:09 -0700
>
> > On Tue, 02 Jun 2009 15:18:50 -0400
> > Ayaz Abdulla <aabdulla@nvidia.com> wrote:
> >
> >> This patch adds support for new ethernet device in the MCP89 chipset.
> >>
> >> Signed-off-by: Ayaz Abdulla <aabdulla@nvidia.com>
> >>
> >
> > It's best to combine these two patches into one, IMO.
>
> Andrew, we do not add new entries to pci_ids.h any more.
Lots of people are still changing it. I believe that the approach
we've been taking is: if the driver presently uses pci_ids.h and you're
adding a new ID then go for it. But new drivers should use a private
site for the IDs. And patches which switch old drivers from pci_ids
over to a private site are approved of.
> Just use the constant directly when using it in the driver
> ID table.
Well OK, but that means that forcedeth has most of its PCI IDs
enumerated in pci_ids.h, but others hardwired in forcedeth.c.
IOW, Ayaz owes us a "[patch] forcedeth: remove PCI IDs from pci_ids.h" ;)
next prev parent reply other threads:[~2009-06-03 21:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-02 19:18 [PATCH 2/2] forcedeth: Addition of new device id Ayaz Abdulla
2009-06-03 20:25 ` Andrew Morton
2009-06-03 21:26 ` David Miller
2009-06-03 21:52 ` Andrew Morton [this message]
2009-06-03 21:57 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090603145238.fd4ece19.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aabdulla@nvidia.com \
--cc=davem@davemloft.net \
--cc=manfred@colorfullife.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).