netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Chris Wright <chrisw@sous-sol.org>
Cc: David Miller <davem@davemloft.net>,
	netdev@vger.kernel.org, Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: [PATCH] tun: virtio net is not compatible with LRO
Date: Wed, 3 Jun 2009 16:52:55 +0930	[thread overview]
Message-ID: <200906031652.56084.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20090603052335.GA20823@sequoia.sous-sol.org>

On Wed, 3 Jun 2009 02:53:35 pm Chris Wright wrote:
> The current failure mode for an LRO device bridged to a virtio device
> (common for KVM) is BUG().  Rather than crashing the host, we can at
> least limp along and give a warning.  lro_flush() will set gso_size,
> but no corresponding gso_type, unlike gro which will eventually call
> ->gro_complete and set up proper gso_type.

So, skb_is_gso() is true, but it's not actually a gso frame?

I know nothing about LRO, but that seems wrong.  If you bridge any other GSO 
device with an LRO device, does that do random things as well?

Thanks,
Rusty.

  reply	other threads:[~2009-06-03  7:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-03  5:23 [PATCH] tun: virtio net is not compatible with LRO Chris Wright
2009-06-03  7:22 ` Rusty Russell [this message]
2009-06-03  7:59   ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200906031652.56084.rusty@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=chrisw@sous-sol.org \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).