netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, gospo@redhat.com,
	Alexander Duyck <alexander.h.duyck@intel.com>,
	Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next PATCH 01/10] ixgbe: use rx_buffer_info->dma instead of nr_frags to determine skb unmap
Date: Thu, 04 Jun 2009 18:59:49 -0700	[thread overview]
Message-ID: <20090605015948.8468.25862.stgit@localhost.localdomain> (raw)

From: Alexander Duyck <alexander.h.duyck@intel.com>

This patch changes the driver so that it uses rx_buffer_info->dma to
determine if it needs to unmap the page instead of sh_info->nr_frags.  This
helps to prevent a cache line miss when receiving small packets as the
rx_buffer_info data should already be in the cache.

Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---

 drivers/net/ixgbe/ixgbe_main.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
index 9684632..e1efa1d 100644
--- a/drivers/net/ixgbe/ixgbe_main.c
+++ b/drivers/net/ixgbe/ixgbe_main.c
@@ -708,7 +708,7 @@ static bool ixgbe_clean_rx_irq(struct ixgbe_q_vector *q_vector,
 		prefetch(skb->data - NET_IP_ALIGN);
 		rx_buffer_info->skb = NULL;
 
-		if (len && !skb_shinfo(skb)->nr_frags) {
+		if (rx_buffer_info->dma) {
 			pci_unmap_single(pdev, rx_buffer_info->dma,
 			                 rx_ring->rx_buf_len,
 			                 PCI_DMA_FROMDEVICE);


             reply	other threads:[~2009-06-05  2:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-05  1:59 Jeff Kirsher [this message]
2009-06-05  2:00 ` [net-next PATCH 02/10] ixgbe: move v_idx into q_vector and use as index only Jeff Kirsher
2009-06-05  2:00 ` [net-next PATCH 03/10] ixgbe: move tx processing into NAPI context Jeff Kirsher
2009-06-05  2:00 ` [net-next PATCH 04/10] ixgbe: Add a second feature flags variable, move HW RSC capability there Jeff Kirsher
2009-06-05  2:01 ` [net-next PATCH 05/10] ixgbe: Add hardware defines for Flow Director for 82599 Jeff Kirsher
2009-06-05  2:01 ` [net-next PATCH 06/10] ixgbe: Add Flow Director init and modify functions " Jeff Kirsher
2009-06-05  2:01 ` [net-next PATCH 07/10] ixgbe: Enable Flow Director hashing in 82599 Jeff Kirsher
2009-06-05  2:02 ` [net-next PATCH 08/10] ixgbe: Re-adjust ring layouts to have better cacheline efficiency Jeff Kirsher
2009-06-05  2:02 ` [net-next PATCH 09/10] ixgbe: Add FW detection and warning for 82599 SFP+ adapters Jeff Kirsher
2009-06-05  2:02 ` [net-next PATCH 10/10] ixgbe: Increase the driver version number Jeff Kirsher
2009-06-07 13:15 ` [net-next PATCH 01/10] ixgbe: use rx_buffer_info->dma instead of nr_frags to determine skb unmap David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090605015948.8468.25862.stgit@localhost.localdomain \
    --to=jeffrey.t.kirsher@intel.com \
    --cc=alexander.h.duyck@intel.com \
    --cc=davem@davemloft.net \
    --cc=gospo@redhat.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).