From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, gospo@redhat.com,
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next PATCH 08/10] ixgbe: Re-adjust ring layouts to have better cacheline efficiency
Date: Thu, 04 Jun 2009 19:02:04 -0700 [thread overview]
Message-ID: <20090605020203.8468.58021.stgit@localhost.localdomain> (raw)
In-Reply-To: <20090605015948.8468.25862.stgit@localhost.localdomain>
From: Jesse Brandeburg <jesse.brandeburg@intel.com>
This patch rearranges the ixgbe_ring struct to make better use of
cacheline efficiency.
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ixgbe/ixgbe.h | 35 +++++++++++++++++++----------------
1 files changed, 19 insertions(+), 16 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe.h b/drivers/net/ixgbe/ixgbe.h
index f2206e2..cd22323 100644
--- a/drivers/net/ixgbe/ixgbe.h
+++ b/drivers/net/ixgbe/ixgbe.h
@@ -121,19 +121,18 @@ struct ixgbe_queue_stats {
struct ixgbe_ring {
void *desc; /* descriptor ring memory */
- dma_addr_t dma; /* phys. address of descriptor ring */
- unsigned int size; /* length in bytes */
- unsigned int count; /* amount of descriptors */
- unsigned int next_to_use;
- unsigned int next_to_clean;
- u8 atr_sample_rate;
- u8 atr_count;
-
- int queue_index; /* needed for multiqueue queue management */
union {
struct ixgbe_tx_buffer *tx_buffer_info;
struct ixgbe_rx_buffer *rx_buffer_info;
};
+ u8 atr_sample_rate;
+ u8 atr_count;
+ u16 count; /* amount of descriptors */
+ u16 rx_buf_len;
+ u16 next_to_use;
+ u16 next_to_clean;
+
+ u8 queue_index; /* needed for multiqueue queue management */
u16 head;
u16 tail;
@@ -141,20 +140,24 @@ struct ixgbe_ring {
unsigned int total_bytes;
unsigned int total_packets;
- u16 reg_idx; /* holds the special value that gets the hardware register
- * offset associated with this ring, which is different
- * for DCB and RSS modes */
-
#ifdef CONFIG_IXGBE_DCA
/* cpu for tx queue */
int cpu;
#endif
+
+ u16 work_limit; /* max work per interrupt */
+ u16 reg_idx; /* holds the special value that gets
+ * the hardware register offset
+ * associated with this ring, which is
+ * different for DCB and RSS modes
+ */
+
struct ixgbe_queue_stats stats;
unsigned long reinit_state;
+ u64 rsc_count; /* stat for coalesced packets */
- u16 work_limit; /* max work per interrupt */
- u16 rx_buf_len;
- u64 rsc_count; /* stat for coalesced packets */
+ unsigned int size; /* length in bytes */
+ dma_addr_t dma; /* phys. address of descriptor ring */
};
enum ixgbe_ring_f_enum {
next prev parent reply other threads:[~2009-06-05 2:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-05 1:59 [net-next PATCH 01/10] ixgbe: use rx_buffer_info->dma instead of nr_frags to determine skb unmap Jeff Kirsher
2009-06-05 2:00 ` [net-next PATCH 02/10] ixgbe: move v_idx into q_vector and use as index only Jeff Kirsher
2009-06-05 2:00 ` [net-next PATCH 03/10] ixgbe: move tx processing into NAPI context Jeff Kirsher
2009-06-05 2:00 ` [net-next PATCH 04/10] ixgbe: Add a second feature flags variable, move HW RSC capability there Jeff Kirsher
2009-06-05 2:01 ` [net-next PATCH 05/10] ixgbe: Add hardware defines for Flow Director for 82599 Jeff Kirsher
2009-06-05 2:01 ` [net-next PATCH 06/10] ixgbe: Add Flow Director init and modify functions " Jeff Kirsher
2009-06-05 2:01 ` [net-next PATCH 07/10] ixgbe: Enable Flow Director hashing in 82599 Jeff Kirsher
2009-06-05 2:02 ` Jeff Kirsher [this message]
2009-06-05 2:02 ` [net-next PATCH 09/10] ixgbe: Add FW detection and warning for 82599 SFP+ adapters Jeff Kirsher
2009-06-05 2:02 ` [net-next PATCH 10/10] ixgbe: Increase the driver version number Jeff Kirsher
2009-06-07 13:15 ` [net-next PATCH 01/10] ixgbe: use rx_buffer_info->dma instead of nr_frags to determine skb unmap David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090605020203.8468.58021.stgit@localhost.localdomain \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).