* [PATCH net-next 3/3] tun: Fix copy/paste error in tun_get_user
@ 2009-06-05 19:35 Sridhar Samudrala
2009-06-06 21:08 ` Michael S. Tsirkin
0 siblings, 1 reply; 3+ messages in thread
From: Sridhar Samudrala @ 2009-06-05 19:35 UTC (permalink / raw)
To: davem, netdev, mst
Use the right structure while incrementing the offset in tun_get_user.
Signed-off-by: Sridhar Samudrala <sri@us.ibm.com>
diff --git a/drivers/net/tun.c b/drivers/net/tun.c
index 4cda69b..15cfcb2 100644
--- a/drivers/net/tun.c
+++ b/drivers/net/tun.c
@@ -567,7 +567,7 @@ static __inline__ ssize_t tun_get_user(struct
tun_struct *tun,
if (gso.hdr_len > len)
return -EINVAL;
- offset += sizeof(pi);
+ offset += sizeof(gso);
}
if ((tun->flags & TUN_TYPE_MASK) == TUN_TAP_DEV) {
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next 3/3] tun: Fix copy/paste error in tun_get_user
2009-06-05 19:35 [PATCH net-next 3/3] tun: Fix copy/paste error in tun_get_user Sridhar Samudrala
@ 2009-06-06 21:08 ` Michael S. Tsirkin
2009-06-08 7:29 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Michael S. Tsirkin @ 2009-06-06 21:08 UTC (permalink / raw)
To: Sridhar Samudrala; +Cc: davem, netdev
On Fri, Jun 05, 2009 at 12:35:46PM -0700, Sridhar Samudrala wrote:
> Use the right structure while incrementing the offset in tun_get_user.
>
> Signed-off-by: Sridhar Samudrala <sri@us.ibm.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
> diff --git a/drivers/net/tun.c b/drivers/net/tun.c
> index 4cda69b..15cfcb2 100644
> --- a/drivers/net/tun.c
> +++ b/drivers/net/tun.c
> @@ -567,7 +567,7 @@ static __inline__ ssize_t tun_get_user(struct
> tun_struct *tun,
>
> if (gso.hdr_len > len)
> return -EINVAL;
> - offset += sizeof(pi);
> + offset += sizeof(gso);
> }
>
> if ((tun->flags & TUN_TYPE_MASK) == TUN_TAP_DEV) {
>
--
MST
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next 3/3] tun: Fix copy/paste error in tun_get_user
2009-06-06 21:08 ` Michael S. Tsirkin
@ 2009-06-08 7:29 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2009-06-08 7:29 UTC (permalink / raw)
To: mst; +Cc: sri, netdev
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Sun, 7 Jun 2009 00:08:33 +0300
> On Fri, Jun 05, 2009 at 12:35:46PM -0700, Sridhar Samudrala wrote:
>> Use the right structure while incrementing the offset in tun_get_user.
>>
>> Signed-off-by: Sridhar Samudrala <sri@us.ibm.com>
>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-06-08 7:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-05 19:35 [PATCH net-next 3/3] tun: Fix copy/paste error in tun_get_user Sridhar Samudrala
2009-06-06 21:08 ` Michael S. Tsirkin
2009-06-08 7:29 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).