From: David Miller <davem@davemloft.net>
To: mst@redhat.com
Cc: sri@us.ibm.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/3] net: Fix skb_copy_datagram_from_iovec() to pass the right offset
Date: Mon, 08 Jun 2009 00:28:51 -0700 (PDT) [thread overview]
Message-ID: <20090608.002851.249913253.davem@davemloft.net> (raw)
In-Reply-To: <20090606212533.GD28614@redhat.com>
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Sun, 7 Jun 2009 00:25:33 +0300
> On Fri, Jun 05, 2009 at 12:35:40PM -0700, Sridhar Samudrala wrote:
>> I am working on enabling UFO between KVM guests using virtio-net and i have
>> some patches that i got working with 2.6.30-rc8. When i wanted to try them
>> with net-next-2.6, i noticed that virtio-net is not working with that tree.
>>
>> After some debugging, it turned out to be several bugs in the recent patches
>> to fix aio with tun driver, specifically the following 2 commits.
>>
>> http://git.kernel.org/?p=linux/kernel/git/davem/net-next-2.6.git;a=commitdiff;h=0a1ec07a67bd8b0033dace237249654d015efa21
>> http://git.kernel.org/?p=linux/kernel/git/davem/net-next-2.6.git;a=commitdiff;h=6f26c9a7555e5bcca3560919db9b852015077dae
>>
>>
>> Fix the call to memcpy_from_iovecend() in skb_copy_datagram_from_iovec
>> to pass the right iovec offset.
>>
>> Signed-off-by: Sridhar Samudrala <sri@us.ibm.com>
>
> Yes, looks like the bugs were around GSO handling, I was probably
> testing without GSO at the time. I'll go try with GSO now. Thanks for
> fixing these!
>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
Applied.
prev parent reply other threads:[~2009-06-08 7:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-05 19:35 [PATCH net-next 1/3] net: Fix skb_copy_datagram_from_iovec() to pass the right offset Sridhar Samudrala
2009-06-06 21:25 ` Michael S. Tsirkin
2009-06-08 7:28 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090608.002851.249913253.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sri@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).