netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH iproute2 1/2] tc_core: Use double in tc_core_time2tick()
@ 2009-06-09  8:05 Jarek Poplawski
  2009-06-09  8:16 ` [PATCH iproute2 2/2 resend] q_cbq: Fix minidle parameter conversion Jarek Poplawski
  0 siblings, 1 reply; 2+ messages in thread
From: Jarek Poplawski @ 2009-06-09  8:05 UTC (permalink / raw)
  To: Stephen Hemminger
  Cc: Patrick McHardy, Antonio Almeida, David Miller, netdev,
	Martin Devera, Eric Dumazet, Vladimir Ivashchenko,
	Badalian Vyacheslav

CBQ minidle parameter is provided in microseconds, so needs time2tick
conversion.

Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
---

 tc/q_cbq.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tc/q_cbq.c b/tc/q_cbq.c
index c99dc3b..7f2bd0c 100644
--- a/tc/q_cbq.c
+++ b/tc/q_cbq.c
@@ -406,7 +406,7 @@ static int cbq_parse_class_opt(struct qdisc_util *qu, int argc, char **argv, str
 		lss.change |= TCF_CBQ_LSS_EWMA|TCF_CBQ_LSS_AVPKT;
 	}
 	if (lss.change&TCF_CBQ_LSS_MINIDLE) {
-		lss.minidle <<= lss.ewma_log;
+		lss.minidle = tc_core_time2tick(lss.minidle << lss.ewma_log);
 		lss.change |= TCF_CBQ_LSS_EWMA;
 	}
 

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH iproute2 2/2 resend] q_cbq: Fix minidle parameter conversion
  2009-06-09  8:05 [PATCH iproute2 1/2] tc_core: Use double in tc_core_time2tick() Jarek Poplawski
@ 2009-06-09  8:16 ` Jarek Poplawski
  0 siblings, 0 replies; 2+ messages in thread
From: Jarek Poplawski @ 2009-06-09  8:16 UTC (permalink / raw)
  To: Stephen Hemminger
  Cc: Patrick McHardy, Antonio Almeida, David Miller, netdev,
	Martin Devera, Eric Dumazet, Vladimir Ivashchenko,
	Badalian Vyacheslav

On 09-06-2009 10:05, Jarek Poplawski wrote:
> CBQ minidle parameter is provided in microseconds, so needs time2tick
> conversion.

Wrong subject, sorry,
Jarek P.
---------------------> take 2 / resend

CBQ minidle parameter is provided in microseconds, so needs time2tick
conversion.

Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
---

 tc/q_cbq.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tc/q_cbq.c b/tc/q_cbq.c
index c99dc3b..7f2bd0c 100644
--- a/tc/q_cbq.c
+++ b/tc/q_cbq.c
@@ -406,7 +406,7 @@ static int cbq_parse_class_opt(struct qdisc_util *qu, int argc, char **argv, str
 		lss.change |= TCF_CBQ_LSS_EWMA|TCF_CBQ_LSS_AVPKT;
 	}
 	if (lss.change&TCF_CBQ_LSS_MINIDLE) {
-		lss.minidle <<= lss.ewma_log;
+		lss.minidle = tc_core_time2tick(lss.minidle << lss.ewma_log);
 		lss.change |= TCF_CBQ_LSS_EWMA;
 	}
 

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-06-09  8:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-09  8:05 [PATCH iproute2 1/2] tc_core: Use double in tc_core_time2tick() Jarek Poplawski
2009-06-09  8:16 ` [PATCH iproute2 2/2 resend] q_cbq: Fix minidle parameter conversion Jarek Poplawski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).