From: Stephen Hemminger <shemminger@vyatta.com>
To: Patrick McHardy <kaber@trash.net>
Cc: Jay Vosburgh <fubar@us.ibm.com>, Arnd Bergmann <arnd@arndb.de>,
"David S. Miller" <davem@davemloft.net>,
bonding-devel@lists.sf.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] bonding: fix multiple module load problem
Date: Tue, 9 Jun 2009 10:23:29 -0700 [thread overview]
Message-ID: <20090609102329.565e9019@nehalam> (raw)
In-Reply-To: <4A2E8D62.6090004@trash.net>
Some users still load bond module multiple times to create bonding
devices. This accidentally was broken when sysfs interface was added.
Note: sysfs and procfs still produce WARN() messages when this is done
so the sysfs method is the recommended API.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
---
Patch against 2.6.30-rc8
--- a/drivers/net/bonding/bond_sysfs.c 2009-06-09 10:07:29.618979856 -0700
+++ b/drivers/net/bonding/bond_sysfs.c 2009-06-09 10:18:04.039973238 -0700
@@ -1538,6 +1538,7 @@ int bond_create_sysfs(void)
printk(KERN_ERR
"network device named %s already exists in sysfs",
class_attr_bonding_masters.attr.name);
+ ret = 0;
}
return ret;
next prev parent reply other threads:[~2009-06-09 17:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-08 22:11 BUG: bonding module can only be loaded once Stephen Hemminger
2009-06-09 12:06 ` Arnd Bergmann
2009-06-09 15:02 ` Stephen Hemminger
2009-06-09 15:33 ` Patrick McHardy
2009-06-09 16:14 ` Jay Vosburgh
2009-06-09 16:27 ` Patrick McHardy
2009-06-09 17:23 ` Stephen Hemminger [this message]
2009-06-09 17:37 ` [Bonding-devel] [PATCH] bonding: fix multiple module load problem Jay Vosburgh
2009-06-09 17:24 ` [Bonding-devel] BUG: bonding module can only be loaded once Jay Vosburgh
2009-06-09 22:14 ` Patrick McHardy
2009-06-10 13:19 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090609102329.565e9019@nehalam \
--to=shemminger@vyatta.com \
--cc=arnd@arndb.de \
--cc=bonding-devel@lists.sf.net \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).