From mboxrd@z Thu Jan 1 00:00:00 1970 From: Frederic Weisbecker Subject: Re: [PATCH RESEND] ftrace: change the export format of trace_kfree_skb() Date: Tue, 9 Jun 2009 20:27:32 +0200 Message-ID: <20090609182730.GA6057@nowhere> References: <4A2DF91F.7030906@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Ingo , LKML , netdev@vger.kernel.org, Steven Rostedt , David Miller , Neil Horman To: Xiao Guangrong Return-path: Received: from mail-ew0-f210.google.com ([209.85.219.210]:40381 "EHLO mail-ew0-f210.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751579AbZFIS1f (ORCPT ); Tue, 9 Jun 2009 14:27:35 -0400 Content-Disposition: inline In-Reply-To: <4A2DF91F.7030906@cn.fujitsu.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Jun 09, 2009 at 01:54:39PM +0800, Xiao Guangrong wrote: > Use %pf instead of %p to output the function's address, use 0x%04X instead > of %u to output the skb's protocol > > Before patch: > > -0 [000] 60144.542521: kfree_skb: skbaddr=de7b8240 protocol=2048 location=c1365429 > -0 [000] 60164.488153: kfree_skb: skbaddr=da66f900 protocol=2048 location=c1365429 > -0 [000] 60193.493933: kfree_skb: skbaddr=deaeb480 protocol=4 location=c134ec25 > -0 [000] 60253.118421: kfree_skb: skbaddr=de7c4900 protocol=4 location=c134ec25 > > After patch: > > bash-2587 [001] 97685.781173: kfree_skb: skbaddr=deb9cc00 protocol=0x0000 location=netlink_unicast > bash-2587 [000] 97686.501121: kfree_skb: skbaddr=df9bb840 protocol=0x0000 location=netlink_unicast > -0 [000] 97696.200184: kfree_skb: skbaddr=df741240 protocol=0x0800 location=ip_rcv > -0 [000] 97696.200198: kfree_skb: skbaddr=dfb3de40 protocol=0x0800 location=ip_rcv > > Signed-off-by: Xiao Guangrong Acked-by: Frederic Weisbecker Would you also be interested in adding the conversion from raw numeric protocol to its name defined in include/linux/if_ether.h I guess __print_flags() can be used for that. Thanks, Frederic. > --- > > Recover the file mode of include/trace/events/skb.h > > --- > include/trace/events/skb.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/include/trace/events/skb.h b/include/trace/events/skb.h > index 1e8fabb..a58bef8 100644 > --- a/include/trace/events/skb.h > +++ b/include/trace/events/skb.h > @@ -30,7 +30,7 @@ TRACE_EVENT(kfree_skb, > __entry->location = location; > ), > > - TP_printk("skbaddr=%p protocol=%u location=%p", > + TP_printk("skbaddr=%p protocol=0x%04X location=%pf", > __entry->skbaddr, __entry->protocol, __entry->location) > ); > > -- > 1.6.1.2 >