From: David Miller <davem@davemloft.net>
To: yevgenyp@mellanox.co.il
Cc: netdev@vger.kernel.org, tziporet@mellanox.co.il
Subject: Re: [PATCH] mlx4_en: added pci_device_id table
Date: Thu, 11 Jun 2009 03:05:27 -0700 (PDT) [thread overview]
Message-ID: <20090611.030527.14497101.davem@davemloft.net> (raw)
In-Reply-To: <4A2E5B5B.7060701@mellanox.co.il>
From: Yevgeny Petrilin <yevgenyp@mellanox.co.il>
Date: Tue, 09 Jun 2009 15:53:47 +0300
> This is required to ensure that mlx4_en module loads on boot when
> there are ConnectX devices installed.
> The driver is compound from two modules: mlx4_core, the low level module
> and mlx4_en. Currently mlx4_core is the only module that is loaded on boot,
> this is not enough to enable the ConnectX Ethernet interfaces.
>
> Signed-off-by: Yevgeny Petrilin <yevgenyp@mellanox.co.il>
This is pretty ugly.
Two modules with the same exact module ID table smells like bad
design. I see no harm in you combining all of this code into one
final module object.
next prev parent reply other threads:[~2009-06-11 10:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-09 12:53 [PATCH] mlx4_en: added pci_device_id table Yevgeny Petrilin
2009-06-10 4:37 ` Roland Dreier
2009-06-10 6:37 ` Yevgeny Petrilin
2009-06-11 10:05 ` David Miller [this message]
2009-06-11 14:40 ` Yevgeny Petrilin
2009-06-11 23:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090611.030527.14497101.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=tziporet@mellanox.co.il \
--cc=yevgenyp@mellanox.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).