From: David Miller <davem@davemloft.net>
To: timo.teras@iki.fi
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] neigh: error out pending skbs if netlink invalidates incomplete neigh
Date: Thu, 11 Jun 2009 03:12:15 -0700 (PDT) [thread overview]
Message-ID: <20090611.031215.17106793.davem@davemloft.net> (raw)
In-Reply-To: <4A30D781.2020403@iki.fi>
From: Timo Teräs <timo.teras@iki.fi>
Date: Thu, 11 Jun 2009 13:08:01 +0300
> When the state is changed to FAILED by netlink, the timer is stopped
> and further probes are not tried anymore. This results in that the
> skb's are not errored. The neigh entry is left stale.
>
> The behaviour is flawed currently. Either we need to prevent state
> change from INCOMPLETE -> FAILED via netlink and keep on sending
> probes,
> or flush the queue when userland replies with FAILED. Otherwise the
> neigh entry state is left bad.
Thanks for the explanation, yes this is a problem.
Can you add a little bit more verbosity to your commit message
so that this issue is clearly explained and resubmit your patch?
Thank you!
next prev parent reply other threads:[~2009-06-11 10:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-04 8:40 [PATCH] neigh: error out pending skbs if netlink invalidates incomplete neigh Timo Teras
2009-06-11 10:02 ` David Miller
2009-06-11 10:08 ` Timo Teräs
2009-06-11 10:12 ` David Miller [this message]
2009-06-11 10:32 ` [PATCH] neigh: fix state transition INCOMPLETE->FAILED via Netlink request Timo Teras
2009-06-11 11:16 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090611.031215.17106793.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=timo.teras@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).