From: David Miller <davem@davemloft.net>
To: timo.teras@iki.fi
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] neigh: fix state transition INCOMPLETE->FAILED via Netlink request
Date: Thu, 11 Jun 2009 04:16:45 -0700 (PDT) [thread overview]
Message-ID: <20090611.041645.160293472.davem@davemloft.net> (raw)
In-Reply-To: <1244716345-9407-1-git-send-email-timo.teras@iki.fi>
From: Timo Teras <timo.teras@iki.fi>
Date: Thu, 11 Jun 2009 13:32:25 +0300
> The current code errors out the INCOMPLETE neigh entry skb queue only from
> the timer if maximum probes have been attempted and there has been no reply.
> This also causes the transtion to FAILED state.
>
> However, the neigh entry can be also updated via Netlink to inform that the
> address is unavailable. Currently, neigh_update() just stops the timers and
> leaves the pending skb's unreleased. This results that the clean up code in
> the timer callback is never called, preventing also proper garbage collection.
>
> This fixes neigh_update() to process the pending skb queue immediately if
> INCOMPLETE -> FAILED state transtion occurs due to a Netlink request.
>
> Signed-off-by: Timo Teras <timo.teras@iki.fi>
Looks great, applied, thanks!
prev parent reply other threads:[~2009-06-11 11:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-04 8:40 [PATCH] neigh: error out pending skbs if netlink invalidates incomplete neigh Timo Teras
2009-06-11 10:02 ` David Miller
2009-06-11 10:08 ` Timo Teräs
2009-06-11 10:12 ` David Miller
2009-06-11 10:32 ` [PATCH] neigh: fix state transition INCOMPLETE->FAILED via Netlink request Timo Teras
2009-06-11 11:16 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090611.041645.160293472.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=timo.teras@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).