From: David Miller <davem@davemloft.net>
To: dhollis@davehollis.com
Cc: david-b@pacbell.net, netdev@vger.kernel.org, mark@asix.com.tw,
donald@asix.com.tw, louis@asix.com.tw
Subject: Re: [RFC usbnet.c] - Add packet aggregation capability
Date: Thu, 11 Jun 2009 05:38:30 -0700 (PDT) [thread overview]
Message-ID: <20090611.053830.39176651.davem@davemloft.net> (raw)
In-Reply-To: <1244656659.2845.11.camel@localhost.localdomain>
From: David Hollis <dhollis@davehollis.com>
Date: Wed, 10 Jun 2009 13:57:39 -0400
> One item that I have is how to handle the portion in usbnet_probe() that
> sets the hard_start_xmit handler with the change to netdevice_ops:
>
> - net->hard_start_xmit = usbnet_start_xmit;
> + if (info->tx_gather)
> + net->hard_start_xmit = usbnet_bundle_xmit;
> + else
> + net->hard_start_xmit = usbnet_start_xmit;
>
>
> Would it be the most appropriate to merge the
> usbnet_aggregate_skb_xmit() pieces into the existing usbnet_start_xmit
> with appropriate conditionals?
In the current tree you cannot even make this assignment.
Everything must go through a net_device_ops set of methods,
the pointer of which is const.
next prev parent reply other threads:[~2009-06-11 12:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-10 17:57 [RFC usbnet.c] - Add packet aggregation capability David Hollis
2009-06-11 12:38 ` David Miller [this message]
2009-06-11 13:30 ` David Hollis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090611.053830.39176651.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=david-b@pacbell.net \
--cc=dhollis@davehollis.com \
--cc=donald@asix.com.tw \
--cc=louis@asix.com.tw \
--cc=mark@asix.com.tw \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).