netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: john.dykstra1@gmail.com
Cc: akpm@linux-foundation.org, fredrik.arnerup@edgeware.tv,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] Re: IFF_LOWER_UP does not fit in ifr_flags
Date: Thu, 11 Jun 2009 20:57:35 -0700 (PDT)	[thread overview]
Message-ID: <20090611.205735.120685201.davem@davemloft.net> (raw)
In-Reply-To: <1244219047.7969.7.camel@Maple>

From: John Dykstra <john.dykstra1@gmail.com>
Date: Fri, 05 Jun 2009 16:24:07 +0000

> On Fri, 2009-05-29 at 20:50 -0700, Andrew Morton wrote:
>> On Thu, 28 May 2009 14:59:05 +0200 "Fredrik Arnerup" <fredrik.arnerup@edgeware.tv> wrote:
>> 
>> > Documentation/networking/operstates.txt (and netdevice(7)) claims that
>> > the flags IFF_LOWER_UP, IFF_DORMANT and IFF_ECHO can be read from user space
>> > using ioctl() with SIOCGIFFLAGS. Looking in include/linux/if.h however,
>> > the flags are returned in a struct ifreq in the field ifr_flags which
>> > is declared as a short, while the flags are defined as:
>> > 
>> > #define IFF_LOWER_UP    0x10000         /* driver signals L1 up         */
>> > #define IFF_DORMANT     0x20000         /* driver signals dormant       */
>> > #define IFF_ECHO        0x40000         /* echo sent packets            */
> 
> [PATCH] net core: Some interface flags not returned by SIOCGIFFLAGS
 ...
> Reported-by:  "Fredrik Arnerup" <fredrik.arnerup@edgeware.tv>
> Signed-off-by: John Dykstra <john.dykstra1@gmail.com>

Applied, thanks!

      reply	other threads:[~2009-06-12  3:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <89A39FC0957640879F8975880836CF91@edgeware.tv>
2009-05-30  3:50 ` IFF_LOWER_UP does not fit in ifr_flags Andrew Morton
2009-06-05 16:24   ` [PATCH] " John Dykstra
2009-06-12  3:57     ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090611.205735.120685201.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=akpm@linux-foundation.org \
    --cc=fredrik.arnerup@edgeware.tv \
    --cc=john.dykstra1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).