From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, vanhoof@redhat.com, williams@redhat.com,
caitlin.bestler@gmail.com, paul.moore@hp.com, steve@chygwyn.com,
remi.denis-courmont@nokia.com, nhorman@tuxdriver.com,
niv@us.ibm.com
Subject: Re: [RFC v2] net: Introduce recvmmsg socket syscall
Date: Thu, 11 Jun 2009 12:34:46 -0300 [thread overview]
Message-ID: <20090611153444.GE22424@ghostprotocols.net> (raw)
In-Reply-To: <20090611.024100.233245804.davem@davemloft.net>
Em Thu, Jun 11, 2009 at 02:41:00AM -0700, David Miller escreveu:
> From: Arnaldo Carvalho de Melo <acme@redhat.com>
> Date: Thu, 11 Jun 2009 00:40:22 -0300
>
> > + struct compat_timespec *timeout_compat =
> > + (struct compat_timespec *)timeout;
>
> In order for this to build on non-compat platforms, or when
> CONFIG_COMPAT is disabled, you'll need to avoid trying to
> reference compat_timespec.
>
> We get away with compat_msghdr because we define it as a NOP
> in net/compat.h when necessary.
>
> Doing the same, and cleanly, with this non-networking compat knob is
> unlikely to be straightforward.
Done, not like msghdr, but should work, testing now.
Thanks for quickly pointing out this brainfart!
- Arnaldo
next prev parent reply other threads:[~2009-06-11 15:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-11 3:40 [RFC v2] net: Introduce recvmmsg socket syscall Arnaldo Carvalho de Melo
2009-06-11 9:41 ` David Miller
2009-06-11 15:34 ` Arnaldo Carvalho de Melo [this message]
2009-06-12 0:00 ` David Miller
2009-06-11 22:58 ` [RFC v3] " Arnaldo Carvalho de Melo
2009-06-11 18:09 ` [RFC v2] " Paul Moore
2009-06-11 21:53 ` Arnaldo Carvalho de Melo
2009-06-16 20:36 ` Paul Moore
2009-06-12 7:26 ` Rémi Denis-Courmont
2009-06-12 14:19 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090611153444.GE22424@ghostprotocols.net \
--to=acme@redhat.com \
--cc=caitlin.bestler@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=niv@us.ibm.com \
--cc=paul.moore@hp.com \
--cc=remi.denis-courmont@nokia.com \
--cc=steve@chygwyn.com \
--cc=vanhoof@redhat.com \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).