From: Stephen Hemminger <shemminger@vyatta.com>
To: Jay Vosburg <fubar@us.ibm.com>, "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, bonding-devel@lists.sourceforge.net
Subject: [PATCH 2/9] bonding: initialize before registration
Date: Fri, 12 Jun 2009 22:02:45 -0700 [thread overview]
Message-ID: <20090613050421.608811423@vyatta.com> (raw)
In-Reply-To: 20090613050243.100086546@vyatta.com
[-- Attachment #1: bond-prereg.patch --]
[-- Type: text/plain, Size: 828 bytes --]
Avoid a unnecessary carrier state transistion that happens when device
is registered.
Lockdep works better if initialization is done before registration as well.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/drivers/net/bonding/bond_main.c 2009-06-12 07:26:44.441927853 -0700
+++ b/drivers/net/bonding/bond_main.c 2009-06-12 07:27:12.459766764 -0700
@@ -5164,15 +5164,15 @@ int bond_create(const char *name)
goto out_netdev;
}
+ bond_set_lockdep_class(bond_dev);
+
+ netif_carrier_off(bond_dev);
+
res = register_netdevice(bond_dev);
if (res < 0) {
goto out_bond;
}
- bond_set_lockdep_class(bond_dev);
-
- netif_carrier_off(bond_dev);
-
up_write(&bonding_rwsem);
rtnl_unlock(); /* allows sysfs registration of net device */
res = bond_create_sysfs_entry(netdev_priv(bond_dev));
--
next prev parent reply other threads:[~2009-06-13 5:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-13 5:02 [PATCH 0/9] Bonding patches for 2.6.31 Stephen Hemminger
2009-06-13 5:02 ` [PATCH 1/9] bonding: bond_create always called with default parameters Stephen Hemminger
2009-06-13 5:02 ` Stephen Hemminger [this message]
2009-06-13 5:02 ` [PATCH 3/9] Subjec: bonding: remove bonding read/write semaphore Stephen Hemminger
2009-06-13 5:02 ` [PATCH 4/9] bonding: fix destructor Stephen Hemminger
2009-06-13 5:02 ` [PATCH 5/9] bonding: fix style issues Stephen Hemminger
2009-06-13 5:02 ` [PATCH 6/9] bonding: elminate bad refcount code Stephen Hemminger
2009-06-13 5:02 ` [PATCH 7/9] bonding: network device names are case sensative Stephen Hemminger
2009-06-13 5:02 ` [PATCH 8/9] bonding: use is_zero_ether_addr Stephen Hemminger
2009-06-13 5:02 ` [PATCH 9/9] bonding: initialization rework Stephen Hemminger
2009-06-14 6:37 ` [PATCH 0/9] Bonding patches for 2.6.31 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090613050421.608811423@vyatta.com \
--to=shemminger@vyatta.com \
--cc=bonding-devel@lists.sourceforge.net \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).