* [PATCH] net: CNIC depends on PCI.
@ 2009-06-15 18:12 Paul Mundt
2009-06-15 18:24 ` Michael Chan
0 siblings, 1 reply; 2+ messages in thread
From: Paul Mundt @ 2009-06-15 18:12 UTC (permalink / raw)
To: netdev; +Cc: Michael Chan, David S. Miller
Even though this driver does shifty things with UIO to make it less
obvious, it is still PCI dependent:
drivers/net/cnic.c:2395: error: implicit declaration of function 'pci_dev_get'
make[3]: *** [drivers/net/cnic.o] Error 1
make[2]: *** [drivers/net] Error 2
This fixes up the CONFIG_PCI=n case, primarily triggered on
allmodconfig/allyesconfig builds:
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
Cc: Michael Chan <mchan@broadcom.com>
---
drivers/net/Kconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 3b63831..f6d6888 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -2272,8 +2272,7 @@ config BNX2
config CNIC
tristate "Broadcom CNIC support"
- depends on BNX2
- depends on UIO
+ depends on PCI && BNX2 && UIO
help
This driver supports offload features of Broadcom NetXtremeII
gigabit Ethernet cards.
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: CNIC depends on PCI.
2009-06-15 18:12 [PATCH] net: CNIC depends on PCI Paul Mundt
@ 2009-06-15 18:24 ` Michael Chan
0 siblings, 0 replies; 2+ messages in thread
From: Michael Chan @ 2009-06-15 18:24 UTC (permalink / raw)
To: Paul Mundt; +Cc: netdev@vger.kernel.org, David S. Miller
On Mon, 2009-06-15 at 11:12 -0700, Paul Mundt wrote:
> Even though this driver does shifty things with UIO to make it less
> obvious, it is still PCI dependent:
>
> drivers/net/cnic.c:2395: error: implicit declaration of function 'pci_dev_get'
> make[3]: *** [drivers/net/cnic.o] Error 1
> make[2]: *** [drivers/net] Error 2
>
> This fixes up the CONFIG_PCI=n case, primarily triggered on
> allmodconfig/allyesconfig builds:
>
> Signed-off-by: Paul Mundt <lethal@linux-sh.org>
> Cc: Michael Chan <mchan@broadcom.com>
A similar patch is already in James' tree:
http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=babdb788f7ec1a782a52240a5f6dae568f32565f
>
> ---
>
> drivers/net/Kconfig | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index 3b63831..f6d6888 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -2272,8 +2272,7 @@ config BNX2
>
> config CNIC
> tristate "Broadcom CNIC support"
> - depends on BNX2
> - depends on UIO
> + depends on PCI && BNX2 && UIO
> help
> This driver supports offload features of Broadcom NetXtremeII
> gigabit Ethernet cards.
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-06-15 18:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-15 18:12 [PATCH] net: CNIC depends on PCI Paul Mundt
2009-06-15 18:24 ` Michael Chan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).