From: David Miller <davem@davemloft.net>
To: jarkao2@gmail.com
Cc: robert.olsson@its.uu.se, zheng.yan@oracle.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 2/1 v2] Re: [BUG] fib_tries related Oops in 2.6.30
Date: Wed, 17 Jun 2009 18:56:58 -0700 (PDT) [thread overview]
Message-ID: <20090617.185658.226201750.davem@davemloft.net> (raw)
In-Reply-To: <20090615160800.GC2767@ami.dom.local>
From: Jarek Poplawski <jarkao2@gmail.com>
Date: Mon, 15 Jun 2009 18:08:01 +0200
> ipv4: Fix fib_trie rebalancing, part 2
>
> My previous patch, which explicitly delays freeing of tnodes by adding
> them to the list to flush them after the update is finished, isn't
> strict enough. It treats exceptionally tnodes without parent, assuming
> they are newly created, so "invisible" for the read side yet.
>
> But the top tnode doesn't have parent as well, so we have to exclude
> all exceptions (at least until a better way is found). Additionally we
> need to move rcu assignment of this node before flushing, so the
> return type of the trie_rebalance() function is changed.
>
> Reported-by: Yan Zheng <zheng.yan@oracle.com>
> Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
Applied, thanks a lot Jarek.
next prev parent reply other threads:[~2009-06-18 1:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-10 16:05 [BUG] fib_tries related Oops in 2.6.30 Yan Zheng
2009-06-11 14:39 ` Jarek Poplawski
2009-06-12 7:25 ` Jarek Poplawski
2009-06-15 6:53 ` [PATCH] " Jarek Poplawski
2009-06-15 9:32 ` David Miller
2009-06-15 15:25 ` [PATCH 2/1] " Jarek Poplawski
2009-06-15 16:08 ` [PATCH 2/1 v2] " Jarek Poplawski
2009-06-18 1:56 ` David Miller [this message]
2009-06-18 7:23 ` [PATCH 3/1] " Jarek Poplawski
2009-06-18 7:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090617.185658.226201750.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jarkao2@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robert.olsson@its.uu.se \
--cc=zheng.yan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).