From: David Miller <davem@davemloft.net>
To: AAbdulla@nvidia.com
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH] forcedeth: fix dma api mismatches
Date: Thu, 18 Jun 2009 12:02:21 -0700 (PDT) [thread overview]
Message-ID: <20090618.120221.92059096.davem@davemloft.net> (raw)
In-Reply-To: <1FC56210173BB445BD77F608D6FB8D03036AA43501@HQMAIL03.nvidia.com>
From: Ayaz Abdulla <AAbdulla@nvidia.com>
Date: Thu, 18 Jun 2009 10:33:43 -0700
> Doing a quick indentifier search on 2.6.17 shows that
> pci_unmap_page() just calls pci_unmap_single().
You should check more recent kernels.
> I think this will just add extra clutter. We can just add a comment
> in the code instead that they perform the same thing.
It causes log messages with the DMA API debugging layer that checks
whether you match up the calls correctly.
prev parent reply other threads:[~2009-06-18 19:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-18 7:17 [PATCH] forcedeth: fix dma api mismatches Eric Dumazet
2009-06-18 7:46 ` David Miller
2009-06-18 17:33 ` Ayaz Abdulla
2009-06-18 19:02 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090618.120221.92059096.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=AAbdulla@nvidia.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).