From: David Miller <davem@davemloft.net>
To: david-b@pacbell.net
Cc: netdev@vger.kernel.org, aric@sdgsystems.com
Subject: Re: [patch] usbnet cdc_subset: fix issues talking to PXA gadgets
Date: Fri, 19 Jun 2009 01:07:56 -0700 (PDT) [thread overview]
Message-ID: <20090619.010756.193703794.davem@davemloft.net> (raw)
In-Reply-To: <20090619.002403.98174871.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Fri, 19 Jun 2009 00:24:03 -0700 (PDT)
> From: David Brownell <david-b@pacbell.net>
> Date: Fri, 19 Jun 2009 00:11:28 -0700
>
>> From: David Brownell <dbrownell@users.sourceforge.net>
>>
>> The host-side CDC subset driver is binding more specifically
>> than it should ... only to PXA 210/25x/26x Linux-USB gadgets.
>>
>> Loosen that restriction to match the gadget driver itself.
>> This helps various PXA 27x and PXA 3xx devices be happier
>> when talking to Linux hosts; and a few other gadgets too.
>>
>> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
>> Tested-by: Aric D. Blumer <aric@sdgsystems.com>
>> ---
>> Appropriate for -stable ... behaves like a protocol bug.
>
> Applied and queued up for -stable.
David this doesn't even compile:
CC [M] drivers/net/usb/cdc_subset.o
drivers/net/usb/cdc_subset.c:313:32: error: macro "USB_DEVICE_VER" requires 4 arguments, but only 2 given
drivers/net/usb/cdc_subset.c:313: error: 'USB_DEVICE_VER' undeclared here (not in a function)
There is absolutely no excuse for this, really.
next prev parent reply other threads:[~2009-06-19 8:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-19 7:11 [patch] usbnet cdc_subset: fix issues talking to PXA gadgets David Brownell
2009-06-19 7:24 ` David Miller
2009-06-19 8:07 ` David Miller [this message]
2009-06-19 10:13 ` David Brownell
2009-06-19 10:10 ` [patch v2] " David Brownell
2009-06-20 8:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090619.010756.193703794.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aric@sdgsystems.com \
--cc=david-b@pacbell.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).