* [patch] usbnet cdc_subset: fix issues talking to PXA gadgets
@ 2009-06-19 7:11 David Brownell
2009-06-19 7:24 ` David Miller
2009-06-19 10:10 ` [patch v2] " David Brownell
0 siblings, 2 replies; 6+ messages in thread
From: David Brownell @ 2009-06-19 7:11 UTC (permalink / raw)
To: Network development list; +Cc: Aric D. Blumer
From: David Brownell <dbrownell@users.sourceforge.net>
The host-side CDC subset driver is binding more specifically
than it should ... only to PXA 210/25x/26x Linux-USB gadgets.
Loosen that restriction to match the gadget driver itself.
This helps various PXA 27x and PXA 3xx devices be happier
when talking to Linux hosts; and a few other gadgets too.
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Tested-by: Aric D. Blumer <aric@sdgsystems.com>
---
Appropriate for -stable ... behaves like a protocol bug.
drivers/net/usb/cdc_subset.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
--- a/drivers/net/usb/cdc_subset.c
+++ b/drivers/net/usb/cdc_subset.c
@@ -307,9 +307,10 @@ static const struct usb_device_id produc
USB_DEVICE (0x1286, 0x8001), // "blob" bootloader
.driver_info = (unsigned long) &blob_info,
}, {
- // Linux Ethernet/RNDIS gadget on pxa210/25x/26x, second config
- // e.g. Gumstix, current OpenZaurus, ...
- USB_DEVICE_VER (0x0525, 0xa4a2, 0x0203, 0x0203),
+ // Linux Ethernet/RNDIS gadget, mostly on PXA, second config
+ // e.g. Gumstix, current OpenZaurus, ... or anything else
+ // that just enables this gadget option.
+ USB_DEVICE_VER (0x0525, 0xa4a2),
.driver_info = (unsigned long) &linuxdev_info,
},
#endif
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [patch] usbnet cdc_subset: fix issues talking to PXA gadgets
2009-06-19 7:11 [patch] usbnet cdc_subset: fix issues talking to PXA gadgets David Brownell
@ 2009-06-19 7:24 ` David Miller
2009-06-19 8:07 ` David Miller
2009-06-19 10:10 ` [patch v2] " David Brownell
1 sibling, 1 reply; 6+ messages in thread
From: David Miller @ 2009-06-19 7:24 UTC (permalink / raw)
To: david-b; +Cc: netdev, aric
From: David Brownell <david-b@pacbell.net>
Date: Fri, 19 Jun 2009 00:11:28 -0700
> From: David Brownell <dbrownell@users.sourceforge.net>
>
> The host-side CDC subset driver is binding more specifically
> than it should ... only to PXA 210/25x/26x Linux-USB gadgets.
>
> Loosen that restriction to match the gadget driver itself.
> This helps various PXA 27x and PXA 3xx devices be happier
> when talking to Linux hosts; and a few other gadgets too.
>
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
> Tested-by: Aric D. Blumer <aric@sdgsystems.com>
> ---
> Appropriate for -stable ... behaves like a protocol bug.
Applied and queued up for -stable.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] usbnet cdc_subset: fix issues talking to PXA gadgets
2009-06-19 7:24 ` David Miller
@ 2009-06-19 8:07 ` David Miller
2009-06-19 10:13 ` David Brownell
0 siblings, 1 reply; 6+ messages in thread
From: David Miller @ 2009-06-19 8:07 UTC (permalink / raw)
To: david-b; +Cc: netdev, aric
From: David Miller <davem@davemloft.net>
Date: Fri, 19 Jun 2009 00:24:03 -0700 (PDT)
> From: David Brownell <david-b@pacbell.net>
> Date: Fri, 19 Jun 2009 00:11:28 -0700
>
>> From: David Brownell <dbrownell@users.sourceforge.net>
>>
>> The host-side CDC subset driver is binding more specifically
>> than it should ... only to PXA 210/25x/26x Linux-USB gadgets.
>>
>> Loosen that restriction to match the gadget driver itself.
>> This helps various PXA 27x and PXA 3xx devices be happier
>> when talking to Linux hosts; and a few other gadgets too.
>>
>> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
>> Tested-by: Aric D. Blumer <aric@sdgsystems.com>
>> ---
>> Appropriate for -stable ... behaves like a protocol bug.
>
> Applied and queued up for -stable.
David this doesn't even compile:
CC [M] drivers/net/usb/cdc_subset.o
drivers/net/usb/cdc_subset.c:313:32: error: macro "USB_DEVICE_VER" requires 4 arguments, but only 2 given
drivers/net/usb/cdc_subset.c:313: error: 'USB_DEVICE_VER' undeclared here (not in a function)
There is absolutely no excuse for this, really.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] usbnet cdc_subset: fix issues talking to PXA gadgets
2009-06-19 8:07 ` David Miller
@ 2009-06-19 10:13 ` David Brownell
0 siblings, 0 replies; 6+ messages in thread
From: David Brownell @ 2009-06-19 10:13 UTC (permalink / raw)
To: David Miller; +Cc: netdev, aric
On Friday 19 June 2009, David Miller wrote:
> David this doesn't even compile:
Sorry, my bad. Fixed in the followup.
> CC [M] drivers/net/usb/cdc_subset.o
> drivers/net/usb/cdc_subset.c:313:32: error: macro "USB_DEVICE_VER" requires 4 arguments, but only 2 given
> drivers/net/usb/cdc_subset.c:313: error: 'USB_DEVICE_VER' undeclared here (not in a function)
>
> There is absolutely no excuse for this, really.
Sure there is: sent it out too soon, before the compile test!
^ permalink raw reply [flat|nested] 6+ messages in thread
* [patch v2] usbnet cdc_subset: fix issues talking to PXA gadgets
2009-06-19 7:11 [patch] usbnet cdc_subset: fix issues talking to PXA gadgets David Brownell
2009-06-19 7:24 ` David Miller
@ 2009-06-19 10:10 ` David Brownell
2009-06-20 8:22 ` David Miller
1 sibling, 1 reply; 6+ messages in thread
From: David Brownell @ 2009-06-19 10:10 UTC (permalink / raw)
To: Network development list; +Cc: Aric D. Blumer
From: David Brownell <dbrownell@users.sourceforge.net>
The host-side CDC subset driver is binding more specifically
than it should ... only to PXA 210/25x/26x Linux-USB gadgets.
Loosen that restriction to match the gadget driver driver.
This will various PXA 27x and PXA 3xx devices happier when
talking to Linux hosts, potentially others.
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Tested-by: Aric D. Blumer <aric@sdgsystems.com>
---
Updated: typo fixed.
drivers/net/usb/cdc_subset.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
--- a/drivers/net/usb/cdc_subset.c
+++ b/drivers/net/usb/cdc_subset.c
@@ -307,9 +307,10 @@ static const struct usb_device_id produc
USB_DEVICE (0x1286, 0x8001), // "blob" bootloader
.driver_info = (unsigned long) &blob_info,
}, {
- // Linux Ethernet/RNDIS gadget on pxa210/25x/26x, second config
- // e.g. Gumstix, current OpenZaurus, ...
- USB_DEVICE_VER (0x0525, 0xa4a2, 0x0203, 0x0203),
+ // Linux Ethernet/RNDIS gadget, mostly on PXA, second config
+ // e.g. Gumstix, current OpenZaurus, ... or anything else
+ // that just enables this gadget option.
+ USB_DEVICE (0x0525, 0xa4a2),
.driver_info = (unsigned long) &linuxdev_info,
},
#endif
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [patch v2] usbnet cdc_subset: fix issues talking to PXA gadgets
2009-06-19 10:10 ` [patch v2] " David Brownell
@ 2009-06-20 8:22 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2009-06-20 8:22 UTC (permalink / raw)
To: david-b; +Cc: netdev, aric
From: David Brownell <david-b@pacbell.net>
Date: Fri, 19 Jun 2009 03:10:03 -0700
> From: David Brownell <dbrownell@users.sourceforge.net>
>
> The host-side CDC subset driver is binding more specifically
> than it should ... only to PXA 210/25x/26x Linux-USB gadgets.
>
> Loosen that restriction to match the gadget driver driver.
> This will various PXA 27x and PXA 3xx devices happier when
> talking to Linux hosts, potentially others.
>
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
> Tested-by: Aric D. Blumer <aric@sdgsystems.com>
Applied.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-06-20 8:21 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-19 7:11 [patch] usbnet cdc_subset: fix issues talking to PXA gadgets David Brownell
2009-06-19 7:24 ` David Miller
2009-06-19 8:07 ` David Miller
2009-06-19 10:13 ` David Brownell
2009-06-19 10:10 ` [patch v2] " David Brownell
2009-06-20 8:22 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).