From: David Miller <davem@davemloft.net>
To: davej@redhat.com
Cc: netdev@vger.kernel.org
Subject: Re: velocity driver unmaps incorrect size.
Date: Sun, 21 Jun 2009 19:42:48 -0700 (PDT) [thread overview]
Message-ID: <20090621.194248.72335974.davem@davemloft.net> (raw)
In-Reply-To: <20090622024044.GA3157@redhat.com>
From: Dave Jones <davej@redhat.com>
Date: Sun, 21 Jun 2009 22:40:44 -0400
> On Sun, Jun 21, 2009 at 06:43:45PM -0700, David Miller wrote:
>
> > Is it possible that for some reason
> > your build is forcing VELOCITY_ZERO_COPY_SUPPORT to be defined
> > for some reason?
>
> Memory corruption maybe?
> It's especially odd in that it only happens once during boot,
> and never happens again. This is my firewall/router, so there's
> more packets going through that box than any other I have.
I would not be inclined to this theory. Regardless of what garbage is
read from skb->len, it's always going to be at least ETH_ZLEN due to
the "max of skb->len and ETH_ZLEN" assignment there.
> btw, given the zerocopy stuff has been disabled for so long,
> is it worth keeping it ?
I'm pretty sure it should be tossed. I wonder if anyone even tries
to build that code these days.
next prev parent reply other threads:[~2009-06-22 2:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-21 17:37 velocity driver unmaps incorrect size Dave Jones
2009-06-22 1:43 ` David Miller
2009-06-22 2:40 ` Dave Jones
2009-06-22 2:42 ` David Miller [this message]
2009-06-22 2:51 ` Dave Jones
2009-06-22 3:37 ` [PATCH] Fix velocity driver unmapping " Dave Jones
2009-06-22 5:15 ` Dave Jones
2009-06-22 5:35 ` [PATCH v2] " Dave Jones
2009-06-22 5:42 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090621.194248.72335974.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=davej@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).