netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: nooiwa@miraclelinux.com
Cc: mchan@broadcom.com, netdev@vger.kernel.org
Subject: Re: [PATCH] bnx2: Fix the behavior of ethtool when ONBOOT=no
Date: Wed, 24 Jun 2009 00:16:25 -0700 (PDT)	[thread overview]
Message-ID: <20090624.001625.113516382.davem@davemloft.net> (raw)
In-Reply-To: <20090624.000852.186373553.davem@davemloft.net>

From: David Miller <davem@davemloft.net>
Date: Wed, 24 Jun 2009 00:08:52 -0700 (PDT)

> From: Naohiro Ooiwa <nooiwa@miraclelinux.com>
> Date: Wed, 24 Jun 2009 14:45:42 +0900
> 
>> Hi Michael
>> 
>> Thank you for your reply.
>> 
>> I tested this patch now.
>> The result was good for me.
> 
> I've applied your patch, thank you.

Actually, you change gives the following build warning.

drivers/net/bnx2.c:7403: warning: initialization from incompatible pointer type

I'll fix it up, but please take care of such trivial issues before
you submit your patch.

Thanks.

  reply	other threads:[~2009-06-24  7:16 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-24  2:57 [PATCH] bnx2: Fix the behavior of ethtool when ONBOOT=no Naohiro Ooiwa
2009-06-24  3:48 ` Michael Chan
2009-06-24  4:43   ` Naohiro Ooiwa
2009-06-24  5:04     ` Michael Chan
2009-06-24  5:45       ` Naohiro Ooiwa
2009-06-24  7:08         ` David Miller
2009-06-24  7:16           ` David Miller [this message]
2009-06-24  8:39             ` Naohiro Ooiwa
2009-06-24 16:43 ` Rick Jones
2009-06-24 16:59   ` Michael Chan
2009-06-24 23:42     ` David Miller
2009-06-24 23:48       ` Michael Chan
2009-06-25  0:12         ` David Miller
2009-06-25  0:25           ` David Miller
2009-06-26  4:30             ` Naohiro Ooiwa
2009-06-29  0:49     ` Naohiro Ooiwa
2009-06-30 14:50       ` Eilon Greenstein
2009-06-30 19:46         ` David Miller
2009-07-02  4:46           ` Naohiro Ooiwa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090624.001625.113516382.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=mchan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=nooiwa@miraclelinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).