netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: mchan@broadcom.com
Cc: rick.jones2@hp.com, nooiwa@miraclelinux.com, netdev@vger.kernel.org
Subject: Re: [PATCH] bnx2: Fix the behavior of ethtool when ONBOOT=no
Date: Wed, 24 Jun 2009 16:42:33 -0700 (PDT)	[thread overview]
Message-ID: <20090624.164233.166634429.davem@davemloft.net> (raw)
In-Reply-To: <1245862760.12000.507.camel@nseg_linux_HP1.broadcom.com>

From: "Michael Chan" <mchan@broadcom.com>
Date: Wed, 24 Jun 2009 09:59:20 -0700

> On Wed, 2009-06-24 at 09:43 -0700, Rick Jones wrote:
>> Why?  Sure, there is no IP on the link, but does that mean the link is 
>> otherwise unusable?  Is ethtool only about IP status?
>> 
> 
> Once the device is closed, we no longer keep track of the link state and
> no longer have register access to determine the link state.  So we
> assume it is down.  In reality, it may still be up if WoL is enabled or
> management firmware is running, but the driver can no longer keep track
> of it.  If we have to assume one or the other, I think it is more
> correct to assume it is down.

This is a big problem.  I misread this situation when I decided to
apply the patch yesterday, sorry.  We're going to have to revert it.

Applications like NetworkManager decide which devices to bring up and
attempt DHCP etc. on based upon the link status.

So if we report link down, the interface won't even be tried even if a
cable is plugged in.

Actually I wonder, does NM bring the interface "up" before checking
link state?  Does anyone know?

  reply	other threads:[~2009-06-24 23:42 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-24  2:57 [PATCH] bnx2: Fix the behavior of ethtool when ONBOOT=no Naohiro Ooiwa
2009-06-24  3:48 ` Michael Chan
2009-06-24  4:43   ` Naohiro Ooiwa
2009-06-24  5:04     ` Michael Chan
2009-06-24  5:45       ` Naohiro Ooiwa
2009-06-24  7:08         ` David Miller
2009-06-24  7:16           ` David Miller
2009-06-24  8:39             ` Naohiro Ooiwa
2009-06-24 16:43 ` Rick Jones
2009-06-24 16:59   ` Michael Chan
2009-06-24 23:42     ` David Miller [this message]
2009-06-24 23:48       ` Michael Chan
2009-06-25  0:12         ` David Miller
2009-06-25  0:25           ` David Miller
2009-06-26  4:30             ` Naohiro Ooiwa
2009-06-29  0:49     ` Naohiro Ooiwa
2009-06-30 14:50       ` Eilon Greenstein
2009-06-30 19:46         ` David Miller
2009-07-02  4:46           ` Naohiro Ooiwa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090624.164233.166634429.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=mchan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=nooiwa@miraclelinux.com \
    --cc=rick.jones2@hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).