From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] bnx2: Fix the behavior of ethtool when ONBOOT=no Date: Wed, 24 Jun 2009 16:42:33 -0700 (PDT) Message-ID: <20090624.164233.166634429.davem@davemloft.net> References: <4A41961B.2090206@miraclelinux.com> <4A4257B8.2090105@hp.com> <1245862760.12000.507.camel@nseg_linux_HP1.broadcom.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: rick.jones2@hp.com, nooiwa@miraclelinux.com, netdev@vger.kernel.org To: mchan@broadcom.com Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:60121 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752305AbZFXXm2 (ORCPT ); Wed, 24 Jun 2009 19:42:28 -0400 In-Reply-To: <1245862760.12000.507.camel@nseg_linux_HP1.broadcom.com> Sender: netdev-owner@vger.kernel.org List-ID: From: "Michael Chan" Date: Wed, 24 Jun 2009 09:59:20 -0700 > On Wed, 2009-06-24 at 09:43 -0700, Rick Jones wrote: >> Why? Sure, there is no IP on the link, but does that mean the link is >> otherwise unusable? Is ethtool only about IP status? >> > > Once the device is closed, we no longer keep track of the link state and > no longer have register access to determine the link state. So we > assume it is down. In reality, it may still be up if WoL is enabled or > management firmware is running, but the driver can no longer keep track > of it. If we have to assume one or the other, I think it is more > correct to assume it is down. This is a big problem. I misread this situation when I decided to apply the patch yesterday, sorry. We're going to have to revert it. Applications like NetworkManager decide which devices to bring up and attempt DHCP etc. on based upon the link status. So if we report link down, the interface won't even be tried even if a cable is plugged in. Actually I wonder, does NM bring the interface "up" before checking link state? Does anyone know?