From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: akpm@linux-foundation.org, netdev@vger.kernel.org,
olver@hartkopp.net, bugzilla-daemon@bugzilla.kernel.org,
bugme-daemon@bugzilla.kernel.org, pm@debian.org
Subject: Re: [Bugme-new] [Bug 13627] New: Tunnel device ignores TCP/UDP traffic
Date: Fri, 26 Jun 2009 19:22:47 -0700 (PDT) [thread overview]
Message-ID: <20090626.192247.17381002.davem@davemloft.net> (raw)
In-Reply-To: <20090627020403.GB19639@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Sat, 27 Jun 2009 10:04:03 +0800
> On Fri, Jun 26, 2009 at 12:44:44PM -0700, Andrew Morton wrote:
>>
>> It's a post-2.6.30 regression which Paul has bisected down to
>>
>> commit d55d87fdff8252d0e2f7c28c2d443aee17e9d70f
>> Author: Herbert Xu <herbert@gondor.apana.org.au>
>> AuthorDate: Mon Jun 22 02:25:25 2009 +0000
>> Commit: David S. Miller <davem@davemloft.net>
>> CommitDate: Tue Jun 23 16:36:25 2009 -0700
>>
>> net: Move rx skb_orphan call to where needed
>>
>> (thanks for doing the bisection!)
>
> Doh, I'd forgotten about transparent proxying.
>
> inet: Call skb_orphan before tproxy activates
>
> As transparent proxying looks up the socket early and assigns
> it to the skb for later processing, we must drop any existing
> socket ownership prior to that in order to distinguish between
> the case where tproxy is active and where it is not.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Applied, thanks Herbert.
next prev parent reply other threads:[~2009-06-27 2:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-13627-10286@http.bugzilla.kernel.org/>
2009-06-26 19:44 ` [Bugme-new] [Bug 13627] New: Tunnel device ignores TCP/UDP traffic Andrew Morton
2009-06-26 20:02 ` David Miller
2009-06-26 20:02 ` David Miller
2009-06-26 20:51 ` Oliver Hartkopp
2009-06-27 2:04 ` Herbert Xu
2009-06-27 2:22 ` David Miller [this message]
2009-06-27 16:37 ` Oliver Hartkopp
2009-06-28 4:55 ` David Miller
2009-06-28 10:28 ` Paul Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090626.192247.17381002.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=bugme-daemon@bugzilla.kernel.org \
--cc=bugzilla-daemon@bugzilla.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=olver@hartkopp.net \
--cc=pm@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).