netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jesper Dangaard Brouer <hawk@comx.dk>
To: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, Jesper Dangaard Brouer <hawk@comx.dk>
Subject: [PATCH 5/5] decnet: Use rcu_barrier() on module unload.
Date: Fri, 26 Jun 2009 22:46:08 +0200	[thread overview]
Message-ID: <20090626204608.10664.84674.stgit@localhost> (raw)
In-Reply-To: <20090626204152.10664.69628.stgit@localhost>

The decnet module unloading as been disabled with a '#if 0' statement,
because it have had issues.

We add a rcu_barrier() anyhow for correctness.

The maintainer (Chrissie Caulfield) will look into the unload issue
when time permits.

Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Acked-by: Chrissie Caulfield <christine.caulfield@googlemail.com>
Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk>
---

 net/decnet/af_decnet.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/net/decnet/af_decnet.c b/net/decnet/af_decnet.c
index d351b8d..77d4028 100644
--- a/net/decnet/af_decnet.c
+++ b/net/decnet/af_decnet.c
@@ -2413,6 +2413,8 @@ static void __exit decnet_exit(void)
 	proc_net_remove(&init_net, "decnet");
 
 	proto_unregister(&dn_proto);
+
+	rcu_barrier_bh(); /* Wait for completion of call_rcu_bh()'s */
 }
 module_exit(decnet_exit);
 #endif


  parent reply	other threads:[~2009-06-26 20:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-26 20:45 [PATCH 0/5] rcu_barrier: Resubmitting the the networking bits Jesper Dangaard Brouer
2009-06-26 20:45 ` [PATCH 1/5] bridge: Use rcu_barrier() instead of syncronize_net() on unload Jesper Dangaard Brouer
2009-06-26 20:45 ` [PATCH 2/5] mac80211: Use rcu_barrier() " Jesper Dangaard Brouer
2009-06-26 20:45 ` [PATCH 3/5] sunrpc: " Jesper Dangaard Brouer
2009-06-26 20:46 ` [PATCH 4/5] ipv6: Use rcu_barrier() on module unload Jesper Dangaard Brouer
2009-06-26 20:46 ` Jesper Dangaard Brouer [this message]
2009-06-26 20:52 ` [PATCH 0/5] rcu_barrier: Resubmitting the the networking bits David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090626204608.10664.84674.stgit@localhost \
    --to=hawk@comx.dk \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).