From: David Miller <davem@davemloft.net>
To: ajitk@serverengines.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-2.6] be2net: Fix to avoid a crash seen on PPC with LRO and Jumbo frames.
Date: Sun, 28 Jun 2009 17:35:00 -0700 (PDT) [thread overview]
Message-ID: <20090628.173500.193717467.davem@davemloft.net> (raw)
In-Reply-To: <20090626125054.GA25517@serverengines.com>
From: Ajit Khaparde <ajitk@serverengines.com>
Date: Fri, 26 Jun 2009 18:21:07 +0530
> While testing the driver on PPC, we ran into a crash with LRO, Jumbo frames.
> With CONFIG_PPC_64K_PAGES configured (a default in PPC), MAX_SKB_FRAGS drops to 3 and we were crossing the array limits on skb_shinfo(skb)->frags[].
> Now we coalesce the frags from the same physical page into one slot in
> skb_shinfo(skb)->frags[] and go to the next index when the frag is from
> different physical page.
>
> This patch is against the net-2.6 tree.
>
> Signed-off-by: Ajit Khaparde <ajitk@serverengines.com>
This patch looks good, applied, thanks!
prev parent reply other threads:[~2009-06-29 0:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-26 12:51 [PATCH net-2.6] be2net: Fix to avoid a crash seen on PPC with LRO and Jumbo frames Ajit Khaparde
2009-06-29 0:35 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090628.173500.193717467.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ajitk@serverengines.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).