From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org, gospo@redhat.com, stable@kernel.org,
jesse.brandeburg@intel.com, joerg.roedel@amd.com
Subject: Re: [net-2.6 PATCH 4/4] ixgbe: fix unmap length bug
Date: Tue, 30 Jun 2009 19:50:48 -0700 (PDT) [thread overview]
Message-ID: <20090630.195048.267762907.davem@davemloft.net> (raw)
In-Reply-To: <20090630214456.17464.70554.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Tue, 30 Jun 2009 14:44:56 -0700
> From: Jesse Brandeburg <jesse.brandeburg@intel.com>
>
> This patch addresses three WARN_ON statements from DMA-API debug code
>
> ixgbe is mapping more than it unmaps, reduce the length of the map call and
> remove the "used once" local variable.
>
> found by Joerg Roedel <joerg.roedel@amd.com> in 2.6.30, so is a candidate
> for -stable.
>
> in addition, fix missing ->dma = 0 after unmap to prevent double free with
> pci_unmap_single
>
> and lastly, don't unmap (half) pages that aren't mapped.
>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> CC: Joerg Roedel <joerg.roedel@amd.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
next prev parent reply other threads:[~2009-07-01 2:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-30 21:43 [net-2.6 PATCH 1/4] ixgbe: Fix SFP log messages Jeff Kirsher
2009-06-30 21:44 ` [net-2.6 PATCH 2/4] ixgbe: Fix device capabilities of 82599 single speed fiber NICs Jeff Kirsher
2009-07-01 2:50 ` David Miller
2009-06-30 21:44 ` [net-2.6 PATCH 3/4] ixgbe: Fix link capabilities during adapter resets Jeff Kirsher
2009-07-01 2:50 ` David Miller
2009-06-30 21:44 ` [net-2.6 PATCH 4/4] ixgbe: fix unmap length bug Jeff Kirsher
2009-07-01 2:50 ` David Miller [this message]
2009-07-01 2:50 ` [net-2.6 PATCH 1/4] ixgbe: Fix SFP log messages David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090630.195048.267762907.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=joerg.roedel@amd.com \
--cc=netdev@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).