From: David Miller <davem@davemloft.net>
To: afleming@freescale.com
Cc: wfarnsworth@mvista.com, netdev@vger.kernel.org
Subject: Re: [PATCH] phylib: fixes for PHY_RESUMING state changes
Date: Thu, 02 Jul 2009 13:17:53 -0700 (PDT) [thread overview]
Message-ID: <20090702.131753.201104772.davem@davemloft.net> (raw)
In-Reply-To: <3253A2AC-9D19-4B02-8526-0D460C6E409E@freescale.com>
From: Andy Fleming <afleming@freescale.com>
Date: Wed, 1 Jul 2009 19:34:24 -0500
>
> On Jul 1, 2009, at 6:00 PM, Wade Farnsworth wrote:
>
>> The PHY_HALTED state disables phydev->link, but the link will not be
>> updated upon entering PHY_RESUMING. Add a call to phy_read_status()
>> to
>> update the link before entering PHY_RUNNING. If the link is not up at
>> this point, enter the PHY_NOLINK state instead.
>>
>> Also, when transitioning from PHY_RESUMING to PHY_RUNNING, calls to
>> netif_carrier_on() and phydev->adjust_link() are missing. Add the
>> calls
>> similar to the other transitions to PHY_RUNNING.
>>
>> Signed-off-by: Wade Farnsworth <wfarnsworth@mvista.com>
>
> Acked-by: Andy Fleming <afleming@freescale.com>
Applied.
prev parent reply other threads:[~2009-07-02 20:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-01 23:00 [PATCH] phylib: fixes for PHY_RESUMING state changes Wade Farnsworth
2009-07-02 0:34 ` Andy Fleming
2009-07-02 20:17 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090702.131753.201104772.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=afleming@freescale.com \
--cc=netdev@vger.kernel.org \
--cc=wfarnsworth@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).