From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, gospo@redhat.com,
Mallikarjuna R Chilakala <mallikarjuna.chilakala@intel.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-2.6 PATCH 4/4] ixgbe: Not allow 8259x unsupported wol options change from ethtool
Date: Thu, 02 Jul 2009 15:51:10 -0700 [thread overview]
Message-ID: <20090702225110.22746.42383.stgit@localhost.localdomain> (raw)
In-Reply-To: <20090702225012.22746.57218.stgit@localhost.localdomain>
From: Mallikarjuna R Chilakala <mallikarjuna.chilakala@intel.com>
Wake-on-lan is currently only supported by 82599 KX4 devices, in all
other cases return a proper value from ixgbe_wol_exclusion function call.
Otherwise from ethtool we will be able to change wol options of
unsupported 8259x devices.
Signed-off-by: Mallikarjuna R Chilakala <mallikarjuna.chilakala@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ixgbe/ixgbe_ethtool.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethtool.c b/drivers/net/ixgbe/ixgbe_ethtool.c
index 0f7b6a3..2a97800 100644
--- a/drivers/net/ixgbe/ixgbe_ethtool.c
+++ b/drivers/net/ixgbe/ixgbe_ethtool.c
@@ -1830,7 +1830,6 @@ static int ixgbe_wol_exclusion(struct ixgbe_adapter *adapter,
break;
default:
wol->supported = 0;
- retval = 0;
}
return retval;
next prev parent reply other threads:[~2009-07-02 22:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-02 22:50 [net-2.6 PATCH 1/4] ixgbe: fix issues with failing to detect insert of unsupported module Jeff Kirsher
2009-07-02 22:50 ` [net-2.6 PATCH 2/4] ixgbe: fix regression on some 82598 adapters Jeff Kirsher
2009-07-04 2:12 ` David Miller
2009-07-02 22:50 ` [net-2.6 PATCH 3/4] ixgbe: fix inconsistent SFP/SFP+ failure results Jeff Kirsher
2009-07-04 2:12 ` David Miller
2009-07-02 22:51 ` Jeff Kirsher [this message]
2009-07-04 2:12 ` [net-2.6 PATCH 4/4] ixgbe: Not allow 8259x unsupported wol options change from ethtool David Miller
2009-07-04 2:12 ` [net-2.6 PATCH 1/4] ixgbe: fix issues with failing to detect insert of unsupported module David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090702225110.22746.42383.stgit@localhost.localdomain \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=mallikarjuna.chilakala@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).