From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org, gospo@redhat.com, donald.c.skidmore@intel.com
Subject: Re: [net-2.6 PATCH 3/4] ixgbe: fix inconsistent SFP/SFP+ failure results.
Date: Fri, 03 Jul 2009 19:12:19 -0700 (PDT) [thread overview]
Message-ID: <20090703.191219.159352502.davem@davemloft.net> (raw)
In-Reply-To: <20090702225051.22746.79159.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Thu, 02 Jul 2009 15:50:52 -0700
> From: Don Skidmore <donald.c.skidmore@intel.com>
>
> Currently if we loaded the driver, insert an unsupported module, and then
> attempt to "ifconfig up" the device it will be brought down but the netdev
> would not be unregistered. This behavior is different than all other
> code paths. This patch corrects that by down'ing the device and then
> scheduling the sfp_config_module_task tasklet. The tasklet will detect
> this condition (like it does with other code paths) and do the
> unregister_netdev().
>
> I also removed the log message as this condition (an unsupported SFP+
> module) will be logged in sfp_config_module_task.
>
> Signed-off-by: Don Skidmore <donald.c.skidmore@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
next prev parent reply other threads:[~2009-07-04 2:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-02 22:50 [net-2.6 PATCH 1/4] ixgbe: fix issues with failing to detect insert of unsupported module Jeff Kirsher
2009-07-02 22:50 ` [net-2.6 PATCH 2/4] ixgbe: fix regression on some 82598 adapters Jeff Kirsher
2009-07-04 2:12 ` David Miller
2009-07-02 22:50 ` [net-2.6 PATCH 3/4] ixgbe: fix inconsistent SFP/SFP+ failure results Jeff Kirsher
2009-07-04 2:12 ` David Miller [this message]
2009-07-02 22:51 ` [net-2.6 PATCH 4/4] ixgbe: Not allow 8259x unsupported wol options change from ethtool Jeff Kirsher
2009-07-04 2:12 ` David Miller
2009-07-04 2:12 ` [net-2.6 PATCH 1/4] ixgbe: fix issues with failing to detect insert of unsupported module David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090703.191219.159352502.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=donald.c.skidmore@intel.com \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).